Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognate analysis long result is not hidden #1132

Open
vmonakhov opened this issue Jul 23, 2024 · 0 comments
Open

Cognate analysis long result is not hidden #1132

vmonakhov opened this issue Jul 23, 2024 · 0 comments
Assignees
Labels
frontend bug is related to frontend optimization something that improves performance or storage space

Comments

@vmonakhov
Copy link

A long result after cognate analysis should be skipped. We should see:

Skipping text output, too long.

But this does not occur. May be this is correct after some changes in code. Please check it.

You can get steps to reproduce from the sctipt:
https://gitlab.ispras.ru/modis-tests/lingvodoc/-/blob/master/frontend/tests/test_cognate_suggest_match_off.py

From frontend code src/components/CognateAnalysisModal/index.js:

    if (result.length > 1048576 && (this.props.mode === "suggestions" || this.props.mode === "multi_suggestions")) {
      result = this.context("Skipping text output, too long.");
    }
@vmonakhov vmonakhov added optimization something that improves performance or storage space frontend bug is related to frontend labels Jul 23, 2024
@vmonakhov vmonakhov self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend bug is related to frontend optimization something that improves performance or storage space
Projects
None yet
Development

No branches or pull requests

1 participant