Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[credential_definition] type -> vct for sd-jwt and doctype for mdoc cbor #171

Closed
peppelinux opened this issue Nov 23, 2023 · 6 comments
Closed
Assignees
Labels
Milestone

Comments

@peppelinux
Copy link
Member

see #166 (comment)

@peppelinux
Copy link
Member Author

See #170

@fmarino-ipzs
Copy link
Collaborator

see also my comment #166 (comment)

@peppelinux
Copy link
Member Author

@fmarino-ipzs it's not our choice, this comes from the standards OpenID4VC and HAIP

@fmarino-ipzs
Copy link
Collaborator

I fully agree that we must follow the standards, but in OID4VCI we have:

type: REQUIRED. Array designating the types a certain credential type supports according to [[VC_DATA](https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#VC_DATA)], Section 4.3.

Maybe this should be changed accordingly, am I missing something?

@peppelinux
Copy link
Member Author

@fmarino-ipzs the type REQUIRED is defined within the appendix E, related to json-ld

E.1.1. VC Signed as a JWT, Not Using JSON-LD

this means that this is normative only for that credential format

@peppelinux
Copy link
Member Author

Closed by openid/OpenID4VCI@12d5ede

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants