Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Disable exposing groups #479

Open
smulle48 opened this issue Jul 3, 2022 · 6 comments
Open

[Feature] Disable exposing groups #479

smulle48 opened this issue Jul 3, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@smulle48
Copy link

smulle48 commented Jul 3, 2022

Please use the template and fill in all the data requested below!

Problem description
Since exposing groups by default, people using IKEA's old firmware for buttons are experiencing all bulbs, blinds, etc exposed twice.

In the latest firmware for IKEA buttons, they have removed group cast. The old way of controlling lights, was to add bulbs to an group and then bind the button to the group. That way you avoided the infamous "popcorn effect".

The downside of this nice feature, was that even if you would control just one bulb, it has to be in an group. This way you end up with the bulb itself and also an group for that same one bulb.

It could be fixed just by updating the firmware, but that would kill this nice feature the firmware have.

The good thing about the old firmware is that the group cast don't need the controller to be online to function, so even if the controller crash, you can still control all your light, blinds, etc.

Suggested solution
Disable exposing groups by default, and be able to expose them by their group id instead of the friendly name (friendly name accept spaces and non English letters)

Describe alternatives you've considered
Downgrading to an release prior to group exposure was default.

Additional context

Are you willing to contribute to this feature?
Yes

@smulle48 smulle48 added the enhancement New feature or request label Jul 3, 2022
@itavero itavero changed the title [Feature] [Feature] Disable exposing groups Jul 3, 2022
@stale
Copy link

stale bot commented Aug 10, 2022

It appears that this issue did not have an update in quite some time. Please check if you can provide any additional information to help resolve this issue. If there isn't any activity in the next two weeks, this issue will be closed automatically. Thank you for your contributions!

@stale stale bot added the stale label Aug 10, 2022
@itavero itavero self-assigned this Aug 10, 2022
@itavero itavero removed the stale label Aug 10, 2022
@itavero
Copy link
Owner

itavero commented Oct 1, 2022

With regards to "disable exposing groups by default": I think for this, the easiest would be to add an additional configuration item where you can put in all the IDs or friendly names of the groups you do wish to expose.
If it is not in your configuration, all groups are exposed. If it is an empty array, none of the groups will be exposed.

Can you elaborate on "be able to expose them by their group id instead of the friendly name (friendly name accept spaces and non English letters)"?
You should be able to use both in the configuration already.

@smulle48
Copy link
Author

smulle48 commented Oct 1, 2022

With regards to "disable exposing groups by default": I think for this, the easiest would be to add an additional configuration item where you can put in all the IDs or friendly names of the groups you do wish to expose.

If it is not in your configuration, all groups are exposed. If it is an empty array, none of the groups will be exposed.

Can you elaborate on "be able to expose them by their group id instead of the friendly name (friendly name accept spaces and non English letters)"?

You should be able to use both in the configuration already.

That sounds like an nice way to make it work.

The idea of using the id instead of the friendly name is, 1: you avoid troubles with misspelling and 2: if you rename the group, you don't have to update the config, as long as the group id is the same.

@itavero
Copy link
Owner

itavero commented Oct 1, 2022

The idea of using the id instead of the friendly name is, 1: you avoid troubles with misspelling and 2: if you rename the group, you don't have to update the config, as long as the group id is the same.

But you can already use the group ID in the plugin configuration, so no change needed with regard to this?

@smulle48
Copy link
Author

smulle48 commented Oct 1, 2022

The idea of using the id instead of the friendly name is, 1: you avoid troubles with misspelling and 2: if you rename the group, you don't have to update the config, as long as the group id is the same.

But you can already use the group ID in the plugin configuration, so no change needed with regard to this?

I was only thinking about the groups. if it could support both it would be nice too 😁

Just thought it would be easier to maintain on a daily basis, if one used the group id. So if I one day would like to expose group 17, I just put in that id, and not "Basement Gaming Room Second Row Spot" 😀 😀

@itavero
Copy link
Owner

itavero commented Oct 1, 2022

Just thought it would be easier to maintain on a daily basis, if one used the group id. So if I one day would like to expose group 17, I just put in that id, and not "Basement Gaming Room Second Row Spot" 😀 😀

I agree. That's why for the current configuration options, you can already use both.

I think I'll be able to look at this request in more detail in the coming weeks. I'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants