Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually implement .form-inline class #88

Open
Amar-Bolkan opened this issue Mar 29, 2022 · 2 comments
Open

Manually implement .form-inline class #88

Amar-Bolkan opened this issue Mar 29, 2022 · 2 comments
Labels
technical-dept Quick solution that needs to be refactored at a later point in time

Comments

@Amar-Bolkan
Copy link
Contributor

Amar-Bolkan commented Mar 29, 2022 •
edited by Weltraumschaf
Loading

In order to migrate the frontend from Bootstrap 4 to 5 several changes need to be made.
On of those is linked to the removal of the .form-inline class. In the official migration guide it says to replace those classes with the grid system. This is quite an extensive change, instead we choose to simply reimplement the original classes.

Migration guide: https://getbootstrap.com/docs/5.0/migration/#card
Bootstrap 4 implementation of .form-inline: https://stackoverflow.com/questions/67655096/bootstrap-5-form-group-form-row-form-inline-not-working
@Amar-Bolkan Amar-Bolkan added the technical-dept Quick solution that needs to be refactored at a later point in time label Mar 29, 2022
@Amar-Bolkan Amar-Bolkan self-assigned this Mar 29, 2022
@Amar-Bolkan
Copy link
Contributor Author

Amar-Bolkan commented Mar 29, 2022 •
edited by Weltraumschaf
Loading

This issue is caused by issue #81

Amar-Bolkan added a commit that referenced this issue Mar 29, 2022
@Amar-Bolkan
Issue #88: Add Bootstrap 4 implementation of .form-inline class
69126c2
@Weltraumschaf
Copy link
Member

Caused by #81.

@rseedorff rseedorff mentioned this issue Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-dept Quick solution that needs to be refactored at a later point in time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Weltraumschaf @Amar-Bolkan