Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tag references GA workflow which might be outdated #245

Open
aguschin opened this issue Sep 2, 2022 · 0 comments
Open

Git tag references GA workflow which might be outdated #245

aguschin opened this issue Sep 2, 2022 · 0 comments
Labels
enhancement New feature or request limitations GTO limitations

Comments

@aguschin
Copy link
Contributor

aguschin commented Sep 2, 2022

Reported by @mike0sv

Consider a case: you register a model version, promote it, and find out that Github Actions workflow is incorrect (commit 1). You fix it, commit and push, but now to trigger it again with the new workflow, you need to create a Git tag that references new commit (commit 2). To do that, you have to register new model version in commit 2, and promote it.

Often you fix CI workflow by trial-and-error, so it may happen you need to register many extra versions for the model.

GTO does an assumption that a single model version belongs to only one commit, thus you can't mark two commits as having the same model version (probably for good - the model could change). A workaround that comes to mind is to allow creation of Git tag that does a promotion of a version from commit 1, but references different commit - e.g. commit 2. It may look like this [email protected]#dev (it's assumed that v0.0.1 is registered in commit 1).

@aguschin aguschin added the enhancement New feature or request label Sep 2, 2022
@aguschin aguschin added the limitations GTO limitations label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limitations GTO limitations
Projects
None yet
Development

No branches or pull requests

1 participant