You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Odd, this section should be the only logic to encode before submitting to the Kubernetes API, but anecdotally I have seen this issue when working on adding GCP SecretManager support, although it appeared that the fix there was that the Google SDK was returning the contents base64'd.
End-to-end testing suite was recently added to this project, but currently only covers AWS SecretManager, we can re-check the AWS secret manager testing is verifying the content is not double base64 encoded and add testing for vault (#20).
Added log at
secret-manager/pkg/internal/vault/vault.go
Line 150 in 999e7d0
Verified secret is not base64 encoded via logs:
Then looked at the K8S Secret that secret-manager created:
Then I went into controller.go and poked around. Removing base64 encoding like
secretDataMap[secretKey] = secretData
here fixed my problem:secret-manager/pkg/controller/externalsecret/controller.go
Lines 179 to 180 in 8ea959e
I also added logging to verify that the data wasn't already base64 encoded with:
which prints:
Running off my own docker image based on commit 999e7d0.
Ideas? 🤔
The text was updated successfully, but these errors were encountered: