refactor code in users.put handler

Author: itsdorosh

lib/handlers.js

@@ -44,19 +44,19 @@ handlers._users.post = (data, callback) => {
   // check that all required fields are filled out
   const firstName = helpers.requiredParamValidator(data, 'firstName', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
   const lastName = helpers.requiredParamValidator(data, 'lastName', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
   const phone = helpers.requiredParamValidator(data, 'phone', {
     type: 'string',
-    exactLength: 12
+    exactLength: 12,
   });
   const password = helpers.requiredParamValidator(data, 'password', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
   const tosAgreement = helpers.requiredParamValidator(data, 'tosAgreement', {type: 'boolean'});
 
@@ -102,25 +102,25 @@ handlers._users.post = (data, callback) => {
 handlers._users.put = (data, callback) => {
   const firstName = helpers.requiredParamValidator(data, 'firstName', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
   const lastName = helpers.requiredParamValidator(data, 'lastName', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
   const phone = helpers.requiredParamValidator(data, 'phone', {
     type: 'string',
-    exactLength: 12
+    exactLength: 12,
   });
   const password = helpers.requiredParamValidator(data, 'password', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
 
-  const token = typeof (data.headers.token) === "string" ? data.headers.token : false;
-  handlers._tokens.verifyToken(token, phoneValidated, (tokenIsValid) => {
-    if (tokenIsValid) {
-      if (phone) {
+  if (phone) {
+    const token = typeof (data.headers.token) === "string" ? data.headers.token : false;
+    handlers._tokens.verifyToken(token, phone, (tokenIsValid) => {
+      if (tokenIsValid) {
         if (firstName || lastName || password) {
           DataLibrary.read('users', phone, (err, data) => {
             if (!err && data) {
@@ -150,12 +150,12 @@ handlers._users.put = (data, callback) => {
           callback(400, {'Error': "One field at least should be specified"});
         }
       } else {
-        callback(400, {'Error': "Missing required fields"});
+        callback(403, {"Error": "Missing required token in header or token is invalid"})
       }
-    } else {
-      callback(403, {"Error": "Missing required token in header or token is invalid"})
-    }
-  });
+    });
+  } else {
+    callback(400, {'Error': "Missing required fields"});
+  }
 };
 
 // Required fields: phone
@@ -216,12 +216,12 @@ handlers._tokens.get = (data, callback) => {
 handlers._tokens.post = (data, callback) => {
   const phone = helpers.requiredParamValidator(data, 'phone', {
     type: 'string',
-    exactLength: 12
+    exactLength: 12,
   });
 
   const password = helpers.requiredParamValidator(data, 'password', {
     type: 'string',
-    minLength: 1
+    minLength: 1,
   });
 
   if (phone && password) {

package.json

@@ -8,7 +8,8 @@
     "lib": "lib"
   },
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "serve": "npx nodemon index.js"
   },
   "repository": {
     "type": "git",