Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of SQL queries on top of tab #231

Closed
fgilio opened this issue Feb 16, 2018 · 7 comments
Closed

Show number of SQL queries on top of tab #231

fgilio opened this issue Feb 16, 2018 · 7 comments

Comments

@fgilio
Copy link
Contributor

fgilio commented Feb 16, 2018

I think I'd be much more useful that way. Now if the number of queries is high, I have to scroll just to see that number. Also, if for any reason, the number is really high the table gets all laggy when scrolling.

I'm proposing this here before making the PR, cause I saw that there's at least 3 places where this would need to be changed:

Would you like me to make those PRs?

@itsgoingd
Copy link
Owner

Hey,

I'd like to add counters similar to the "Cache" tab - https://underground.works/images/blog/2017-09-29-Introducing-Clockwork-2.0/cache-tab.png - with total number of queries, total execution time and maybe count of read/write queries.

If you'd like to try implementing this feel free to PR the clockwork-chrome repo (other repos are just copies of the Chrome code).

@fgilio
Copy link
Contributor Author

fgilio commented Feb 19, 2018

Sure! I can try 😬

@robclancy
Copy link
Contributor

God yes I need this. When I finally get time to help with clockwork this would be my first priority haha.

@fgilio
Copy link
Contributor Author

fgilio commented May 15, 2018

I forgot to updated this issue. I tried, but failed before fully understanding how the current feature works in the "Cache" tab. I was short of time atm and had to abandon the fight.

@itsgoingd
Copy link
Owner

Hey, no problem, I've already implemented it in the meantime - itsgoingd/clockwork-chrome#52.

There is a whole bunch of feature requests already done for 3.0, I really need to start referencing issues in the PRs, here is an overview for now - #232.

@fgilio
Copy link
Contributor Author

fgilio commented May 17, 2018

Looks awesome, thanks @itsgoingd!

@itsgoingd
Copy link
Owner

Database tab improvements released in Clockwork 3.0 - blog post and full changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants