|
| 1 | +import assert from 'node:assert/strict'; |
| 2 | +import { execFileSync, spawnSync } from 'node:child_process'; |
| 3 | +import { |
| 4 | + mkdir, |
| 5 | + mkdtemp, |
| 6 | + readFile, |
| 7 | + rm, |
| 8 | + writeFile, |
| 9 | +} from 'node:fs/promises'; |
| 10 | +import { tmpdir } from 'node:os'; |
| 11 | +import { dirname, join } from 'node:path'; |
| 12 | +import test from 'node:test'; |
| 13 | + |
| 14 | +const projectRoot = new URL('..', import.meta.url).pathname; |
| 15 | +const hooksPath = join(projectRoot, '.codex', 'hooks.json'); |
| 16 | +const codeownersPath = join(projectRoot, '.github', 'CODEOWNERS'); |
| 17 | +const protectedPaths = [ |
| 18 | + '.codex/hooks.json', |
| 19 | + '.agents/skills/example-hook.mjs', |
| 20 | + 'AGENTS.md', |
| 21 | + 'skills-lock.json', |
| 22 | +]; |
| 23 | + |
| 24 | +function git(repo, ...args) { |
| 25 | + return execFileSync('git', ['-C', repo, ...args], { |
| 26 | + encoding: 'utf8', |
| 27 | + stdio: ['ignore', 'pipe', 'pipe'], |
| 28 | + }).trim(); |
| 29 | +} |
| 30 | + |
| 31 | +const hookManifest = JSON.parse(await readFile(hooksPath, 'utf8')); |
| 32 | + |
| 33 | +function hookCommand() { |
| 34 | + const manifest = hookManifest; |
| 35 | + return manifest.hooks.PostToolUse[0].hooks[0].command; |
| 36 | +} |
| 37 | + |
| 38 | +async function makeCheckout() { |
| 39 | + const repo = await mkdtemp(join(tmpdir(), 'diffsplain-automation-trust-')); |
| 40 | + await mkdir(join(repo, '.codex'), { recursive: true }); |
| 41 | + await mkdir(join(repo, '.agents', 'skills', 'impeccable', 'scripts'), { |
| 42 | + recursive: true, |
| 43 | + }); |
| 44 | + await writeFile(join(repo, '.codex', 'hooks.json'), '{}\n'); |
| 45 | + await writeFile(join(repo, 'AGENTS.md'), 'Instructions\n'); |
| 46 | + await writeFile(join(repo, 'skills-lock.json'), '{}\n'); |
| 47 | + await writeFile( |
| 48 | + join(repo, '.agents', 'skills', 'impeccable', 'scripts', 'hook.mjs'), |
| 49 | + "import { writeFileSync } from 'node:fs';\nwriteFileSync('.hook-ran', 'yes\\n');\n", |
| 50 | + ); |
| 51 | + git(repo, 'init', '-q'); |
| 52 | + git(repo, 'config', 'user.email', 'diffsplain@example.test'); |
| 53 | + git(repo, 'config', 'user.name', 'Diffsplain'); |
| 54 | + git(repo, 'add', '.'); |
| 55 | + git(repo, 'commit', '-qm', 'trusted automation'); |
| 56 | + return repo; |
| 57 | +} |
| 58 | + |
| 59 | +function runHook(repo, env = {}) { |
| 60 | + return spawnSync('sh', ['-c', hookCommand()], { |
| 61 | + cwd: repo, |
| 62 | + encoding: 'utf8', |
| 63 | + env: { ...process.env, ...env }, |
| 64 | + }); |
| 65 | +} |
| 66 | + |
| 67 | +test('skips repo-owned hook code until this checkout revision is trusted', async () => { |
| 68 | + const repo = await makeCheckout(); |
| 69 | + |
| 70 | + try { |
| 71 | + const untrusted = runHook(repo); |
| 72 | + assert.equal(untrusted.status, 0, untrusted.stderr); |
| 73 | + await assert.rejects(readFile(join(repo, '.hook-ran'), 'utf8')); |
| 74 | + assert.match(untrusted.stderr, /trust warning: skipped repo-owned hook automation/i); |
| 75 | + |
| 76 | + const trusted = runHook(repo, { |
| 77 | + DIFFSPLAIN_TRUSTED_AUTOMATION_REV: git(repo, 'rev-parse', 'HEAD'), |
| 78 | + }); |
| 79 | + assert.equal(trusted.status, 0, trusted.stderr); |
| 80 | + assert.equal(await readFile(join(repo, '.hook-ran'), 'utf8'), 'yes\n'); |
| 81 | + } finally { |
| 82 | + await rm(repo, { recursive: true, force: true }); |
| 83 | + } |
| 84 | +}); |
| 85 | + |
| 86 | +test('changes to automation files revoke trust and request review', async () => { |
| 87 | + for (const file of protectedPaths) { |
| 88 | + const repo = await makeCheckout(); |
| 89 | + |
| 90 | + try { |
| 91 | + await mkdir(dirname(join(repo, file)), { recursive: true }); |
| 92 | + await writeFile(join(repo, file), 'changed\n'); |
| 93 | + const result = runHook(repo, { |
| 94 | + DIFFSPLAIN_TRUSTED_AUTOMATION_REV: git(repo, 'rev-parse', 'HEAD'), |
| 95 | + }); |
| 96 | + |
| 97 | + assert.equal(result.status, 0, `${file}: ${result.stderr}`); |
| 98 | + await assert.rejects(readFile(join(repo, '.hook-ran'), 'utf8')); |
| 99 | + assert.match(result.stderr, /trust warning: skipped repo-owned hook automation/i); |
| 100 | + } finally { |
| 101 | + await rm(repo, { recursive: true, force: true }); |
| 102 | + } |
| 103 | + } |
| 104 | +}); |
| 105 | + |
| 106 | +test('staged automation changes also revoke trust', async () => { |
| 107 | + const repo = await makeCheckout(); |
| 108 | + |
| 109 | + try { |
| 110 | + await writeFile(join(repo, 'AGENTS.md'), 'changed\n'); |
| 111 | + git(repo, 'add', 'AGENTS.md'); |
| 112 | + const result = runHook(repo, { |
| 113 | + DIFFSPLAIN_TRUSTED_AUTOMATION_REV: git(repo, 'rev-parse', 'HEAD'), |
| 114 | + }); |
| 115 | + |
| 116 | + assert.equal(result.status, 0, result.stderr); |
| 117 | + await assert.rejects(readFile(join(repo, '.hook-ran'), 'utf8')); |
| 118 | + assert.match(result.stderr, /trust warning: skipped repo-owned hook automation/i); |
| 119 | + } finally { |
| 120 | + await rm(repo, { recursive: true, force: true }); |
| 121 | + } |
| 122 | +}); |
| 123 | + |
| 124 | +test('records vendored hook provenance and protects every trust boundary', async () => { |
| 125 | + const lock = JSON.parse( |
| 126 | + await readFile(join(projectRoot, 'skills-lock.json'), 'utf8'), |
| 127 | + ); |
| 128 | + const codeowners = await readFile(codeownersPath, 'utf8'); |
| 129 | + |
| 130 | + assert.deepEqual(lock.skills.impeccable, { |
| 131 | + source: 'pbakaus/impeccable', |
| 132 | + sourceType: 'github', |
| 133 | + version: '4.0.2', |
| 134 | + skillPath: 'skill/SKILL.md', |
| 135 | + computedHash: 'd61672b057c247542e8a4884d68794e5b0cc1198446d23aae0321180c23f1521', |
| 136 | + }); |
| 137 | + for (const path of ['/.codex/', '/.agents/', '/AGENTS.md', '/skills-lock.json']) { |
| 138 | + assert.match(codeowners, new RegExp(`^${path.replaceAll('.', '\\.')} @itsjling$`, 'm')); |
| 139 | + } |
| 140 | +}); |
0 commit comments