Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download URL #460

Closed
sheepa opened this issue Oct 1, 2024 · 5 comments · Fixed by #468
Closed

Download URL #460

sheepa opened this issue Oct 1, 2024 · 5 comments · Fixed by #468

Comments

@sheepa
Copy link

sheepa commented Oct 1, 2024 •
edited
Loading

The download URL for the server zip have changed from https://minecraft.azureedge.net/bin-linux/bedrock-server-{VERSION}.zip to https://www.minecraft.net/bedrockdedicatedserver/bin-linux/bedrock-server-{VERSION}.zip

This all works fine when specifying LATEST or PREVIEW as the VERSION as it will lookup the correct URL. However when setting a specific version the URL is hardcoded to the old one.

Would it not make sense it let it use the same lookup code or perhaps even allowing setting an environment variable DOWNLOAD_URL that will take precedence if set to allow workarounds for potential future changes?

EDIT: It seems like the old link is now(?) working for all(?) versions except 1.21.31.04.

Thanks!
@itzg itzg moved this to In progress in Docker Minecraft Oct 5, 2024
@itzg itzg added the bug Something isn't working label Oct 5, 2024
@itzg itzg removed this from Docker Minecraft Oct 5, 2024
@itzg itzg removed the bug Something isn't working label Oct 5, 2024
@itzg
Copy link
Owner

itzg commented Oct 5, 2024

EDIT: It seems like the old link is now(?) working for all(?) versions except 1.21.31.04.

In that case, I'd prefer to leave it as is since that version will quickly become lost to the sands of time.

Can this issue be closed then?

@G0phix
Copy link

G0phix commented Oct 6, 2024

The container doesn't start anymore, how to fix this?
WindowsTerminal_xvOvcJmn8m

@itzg
Copy link
Owner

itzg commented Oct 6, 2024

@ThiagoSolfo you posted on the wrong issue. Yours is a duplicate of #458 and has already been fixed. Re-pull the image.

@G0phix
Copy link

G0phix commented Oct 7, 2024

@itzg thanks, it worked

@thedhruvn
Copy link
Contributor

@itzg I made a fix for this, but maybe we don't need it anymore? Do you want me to submit a PR on this?

thedhruvn added a commit to thedhruvn/docker-minecraft-bedrock-server that referenced this issue Oct 8, 2024
@thedhruvn
Fix: eliminated hardcoded URL for custom versions
7a27256 
Old behavior: Custom versions used hardcoded download URL. this URL
should be dynamically sourced using the lookupVersion command instead.

New behavior: lookupVersion takes a second parameter, version, and
uses a simple sed replace to insert the version parameter into the
download URL dynamically, if it was successfully found.

Also, removed old bedrock version shortcuts. This can be restored and
modified to use the lookupVersion command to get the right URL if
needed. It's unclear whether there's any active servers still running
on legacy versions of bedrock (to this author).

Resolves itzg#460
@thedhruvn thedhruvn mentioned this issue Oct 8, 2024
Merged
@itzg itzg closed this as completed in #468 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: eliminated hardcoded URL for custom versions thedhruvn/docker-minecraft-bedrock-server
4 participants
@itzg @sheepa @thedhruvn @G0phix