Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Support #8

Open
sneakingJ opened this issue Nov 29, 2022 · 3 comments
Open

PHP 8 Support #8

sneakingJ opened this issue Nov 29, 2022 · 3 comments

Comments

@sneakingJ
Copy link

Hi,
with the newest changes, it seems this package only works with PHP 7. Could you make it compatible with PHP 8.1 too?
Askancy added a commit to Askancy/howlongtobeat that referenced this issue Apr 10, 2023
@Askancy
Fix for PHP 8 support ivankaizer#8
b114b70
@Askancy
Copy link

Askancy commented Apr 10, 2023

use this: https://github.com/Askancy/howlongtobeat

@sneakingJ
Copy link
Author

use this: https://github.com/Askancy/howlongtobeat

Oh nice, so everything works still fine except the adjustment with the composer.json?

@Askancy
Copy link

Askancy commented Apr 10, 2023

exactly, the problem is having declared the php version in the composer in the last commit.

    "require": {
        "php": "^7.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Askancy @sneakingJ