Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AstroCoordSystem #10

Open
pahjbo opened this issue Apr 27, 2022 · 1 comment
Open

AstroCoordSystem #10

pahjbo opened this issue Apr 27, 2022 · 1 comment

Comments

@pahjbo
Copy link
Member

pahjbo commented Apr 27, 2022

In the model AstroCoordSystem both is a CoordSys and contains a collection of CoordSys - I am not sure that this is really meaningful for an AstroCoordSystem to derive from CoordSys - could an AstroCoordSystem contain an AstroCoordSystem?

@mcdittmar
Copy link
Collaborator

The AstroCoordSystem contains a collection of PhysicalCoordSys (eg: GenericSys + TimeSys + SpaceSys + etc ). It is not allowed to contain AstroCoordSystem.

This hierarchy allows all Coordinate-s to have a single relation to the associated coordinate system (ie: a single vodml-id (Coordinate.coordSys)

Where the model is now, you may be right, that there is no meaningful reason for AstroCoordSystem to derive from CoordSys. The current configuration is consistent with STC-1 and, If I recall correctly, this was useful in the version of this model which allowed construction of multi-dimensional coordinates whose axes were in different domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants