Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 14.3 Analyzer Warnings Related To Assumed Nullability #391

Open
LowAmmo opened this issue May 12, 2023 · 1 comment
Open

Xcode 14.3 Analyzer Warnings Related To Assumed Nullability #391

LowAmmo opened this issue May 12, 2023 · 1 comment

Comments

@LowAmmo
Copy link

LowAmmo commented May 12, 2023

When running Xcode analyzer on our project (and directly on the libPhoneNumber-iOS project), seeing some warnings about passing nil to methods that are expecting it, or returning nil from methods that don't support returning nil.

Working under an assumption that the current code is doing what is desired, I believe the majority of the "issues" are just due to assumed Nullability with methods.

I'm working on a PR that adds nullability specifiers primarily in NBPhoneNumberUtil, but also a few other places that gave warnings.

Everything seems to be benign, so not sure there is actually a problem - but, my OCD appreciates when code analysis doesn't produce any warnings at all. 😄

LowAmmo added a commit to LowAmmo/libPhoneNumber-iOS that referenced this issue May 12, 2023
…unctions

* Address analyzer warnings related to passing nil to non-nil parameters
LowAmmo added a commit to LowAmmo/libPhoneNumber-iOS that referenced this issue May 12, 2023
…unctions

* Address analyzer warnings related to passing nil to non-nil parameters

* Fix build failure with 'ShortNumber' test target
@LowAmmo
Copy link
Author

LowAmmo commented May 12, 2023

Created Pull Request: #392

  • Analyzer returns no issues with any targets (base, Geocoding, or ShortNumber)
  • All tests targets pass successfully

Everything was tested/developed with Xcode 14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant