Fix comment hashtag issue #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered replacing # with a hyphen or other symbol, however I opted for removing the hashtag entirely since I felt it was unlikely to cause too much of an issue. |
|
Replace it with "%23" and I'll get that merged |
|
That bug is actually caused because it's a part of an href, which makes it parsed as a URL. Technically, PDS should really run |
Fix hashtags from ending the file too early URI encodes # symbol
Done! Not sure why I didn't do this in the first place haha. |
mykola2312
pushed a commit
to mykola2312/PowerDeleteSuite
that referenced
this pull request
Jun 30, 2024
Fix comment hashtag issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hashtags from ending the file too early.
Closes #34 and possibly #20.