Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image to Docker Hub automated builds #86

Open
jacksegal opened this issue Jan 5, 2019 · 4 comments
Open

Add Docker image to Docker Hub automated builds #86

jacksegal opened this issue Jan 5, 2019 · 4 comments

Comments

@jacksegal
Copy link
Owner

(taken from PR #83 )

At the moment the Docker image is automagically built via Docker Hub automated builds from @djjudas21 Github fork of this project.

Need to set up automated builds from the master repo & then update README with new URL.

@djjudas21 is happy to explain how to do this.

@jacksegal
Copy link
Owner Author

Hi @djjudas21

I've had a go at setting up an automated build: https://hub.docker.com/r/jacksegal/google-compute-snapshot/

Can you have a look and let me know if it's correct? Mine doesn't have the "Dockerfile" or "Builds" tab that yours does.

Thanks,
Jack

@djjudas21
Copy link
Contributor

It looks OK, I assumed you set it up as an "Automated Build"? If so, you'll need to push a new commit to this repo to trigger an automated build on Docker Hub. Just tweak the readme or something to see if it builds 👍

@jacksegal
Copy link
Owner Author

Thanks @djjudas21 - the last push I did on 7th Jan triggered an automated build on Docker Hub, so I've updated the README with the URL my repo.

Thanks for your contribution 👍

@djjudas21
Copy link
Contributor

I'm still not 100% sure if this is working properly. On my Docker hub page it shows tabs for Dockerfile and Builds, and on the right hand side there is a link for Source Repository. Yours doesn't have any of those, so does this mean it's a non-automated build?

From what I recall, I didn't create the Docker Hub repo manually, I just followed the wizard to add an automated build, linked it to the Github project and it did the rest itself. Is this what you did?

Also, I spotted in your README it still points people towards my Docker image, rather than yours 😄

@jacksegal jacksegal reopened this Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants