Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unapproved comments are emailed out to subscribers before they’re approved #322

Open
da2x opened this issue Dec 4, 2021 · 0 comments
Open

Comments

@da2x
Copy link
Contributor

da2x commented Dec 4, 2021

I don’t have a clear idea of how to fix this one. It’s trivial to stop the emails from going out, but then how do you send it ones the status changes? Also, swapping statuses could send the same message multiple times. The database needs to track whether the comment has been sent out as an email or not. The email sending can’t take place in WriteComments. It should probably be async from the posting request anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant