Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashover 2.0 does not work under PHP 8.2 #335

Open
Torsten-K opened this issue Nov 6, 2022 · 7 comments
Open

Hashover 2.0 does not work under PHP 8.2 #335

Torsten-K opened this issue Nov 6, 2022 · 7 comments

Comments

@Torsten-K
Copy link

Hashover 2.0 does not work under PHP 8.2 on Apache. I receive an error message and a white page:

Deprecated: Creation of dynamic property HashOver\SpamCheck::$ip is deprecated in […]/hashover/backend/classes/spamcheck.php on line 36

Furthermore, login fails with several fatal errors.

@jacobwb
Copy link
Owner

jacobwb commented Nov 6, 2022

Thank you for reporting this, I have yet to test HashOver on PHP 8.2. This change to the language is good. Most of my code is already written to avoid this warning, as dynamic class properties is frowned upon in my coding standard. However, it looks like class properties are being set dynamically in a few places by accident. I will try to get my hands on PHP 8.2 and fix these issues, but in any case, this issue should be fixed when 8.2 is officially released later this month.

@Torsten-K
Copy link
Author

Ah, that sounds nice, thanks for your efforts!

jacobwb added a commit that referenced this issue Nov 6, 2022
jacobwb added a commit that referenced this issue Nov 6, 2022
@jacobwb
Copy link
Owner

jacobwb commented Nov 6, 2022

Can you please give the latest code another try?

@Torsten-K
Copy link
Author

Yes, with pleasure, but not until tomorrow, I think.

@Torsten-K
Copy link
Author

Uhm, where can I download the latest code? It does not seem to have changed (master branch).

@jacobwb
Copy link
Owner

jacobwb commented Nov 8, 2022

You would get it the normal way, with a git pull. If you think you have the latest code, can you please see if it is giving you a different error?

@Torsten-K
Copy link
Author

Sorry for the late reply, I did not find the time to test again, until today. Good news: I can confirm that the latest code works under PHP 8.2.

Only a warning appears in the admin backend, but it is not very annoying and does not seem to affect the functionality:
Warning: file_exists(): open_basedir restriction in effect. File(/docs/de-de) is not within the allowed path(s): (/var/www/[…]:/usr/share/php) in /var/www/[…]/html/[…]/hashover/admin/view-setup.php on line 67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants