Made toc Sidebar Expand to Fit Page, per issue #744 by yurishkuro #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue jaegertracing#744, opened by yurishkuro, I made the sidebar expand to fill the page. Signed-off-by: Donovan Porter <[email protected]> Signed-off-by: Donovan-Porter <[email protected]>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I see it now expands to more than the height of the page. |
|
Yes, I figured it doesn't much matter because of the ample whitespace, but the height could be finetuned. I used 6rem because that's the value of the "$navbar-height" in the "variables.sass" file, but the sidebar's top is below 6rem from the top of the window. I also couldn't seem to get the $navbar-height variable to read properly in the calc() function. Another issue that I didn't catch before submitting the pull request is the doubled scroll bar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #744, opened by yurishkuro, I made the sidebar expand to fill the page.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test