This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Catch exception when connect to report server fails so that it can still work without it; fix the default ports for collector and query servers to make it work again. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill work without it; fix the default ports for collector and query servers to make it work again. Signed-off-by: Jianwu Chen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #47
Short description of the changes
The current version doesn't work out of the box. Mainly due to its dependency on the local reporter server. There's no documentation on how to set the local report server up. So it blocks most users to use this tool. This PR did the following changes to make it buildable and workable with default configurations:
SENDERto HTTP.