Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid snapshot in operationDetailsTable/index.test.js #2659

Open
yurishkuro opened this issue Feb 11, 2025 · 3 comments · May be fixed by #2674
Open

Avoid snapshot in operationDetailsTable/index.test.js #2659

yurishkuro opened this issue Feb 11, 2025 · 3 comments · May be fixed by #2674

Comments

@yurishkuro
Copy link
Member

packages/jaeger-ui/src/components/Monitor/ServicesView/operationDetailsTable/index.test.js

The automated upgrade of AntD in #2658 failed because the snapshot needed to be regenerated, for meaningless changes like this:

-  className="ant-col ant-col-24 css-dev-only-do-not-override-cdzvx5"
+  className="ant-col ant-col-24 css-dev-only-do-not-override-1yacf91"

Our tests should not be depending on implementation details of the 3rd party library. The goal is to rewrite this test using react testing library practices.

@vaishnavi192
Copy link

vaishnavi192 commented Feb 17, 2025

@yurishkuro I would like to work on it. Also the slack link in jaeger homepage is not working. How can I join slack for further discussions?

@yurishkuro
Copy link
Member Author

@Mubashirshariq Mubashirshariq linked a pull request Feb 19, 2025 that will close this issue
4 tasks
@siddhiguptas
Copy link

Hey @yurishkuro !!I'd like to work on this issue..is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants