Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use single ENV var for Encoding/Span types #14

Open
jan25 opened this issue Aug 13, 2019 · 0 comments
Open

Refactor: use single ENV var for Encoding/Span types #14

jan25 opened this issue Aug 13, 2019 · 0 comments

Comments

@jan25
Copy link
Contributor

jan25 commented Aug 13, 2019

Refer to
https://github.com/jaegertracing/xdock-zipkin-brave/blob/master/src/main/java/io/jaegertracing/xdock/zipkin/Application.java#L80 and
https://github.com/jaegertracing/xdock-zipkin-brave/blob/master/docker-compose.yml.

We have ENCODING and JSON_ENCODER to decide the v1 or v2 routes and the Span encoding type. These must be unified and only use a single ENV var.

Similar fixing need to be done in https://github.com/jaegertracing/jaeger/blob/master/crossdock/docker-compose.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant