From bca4c3abb2df407aed1392a639a076f055965d80 Mon Sep 17 00:00:00 2001
From: Trustin Lee <trustin@gmail.com>
Date: Wed, 4 Mar 2009 10:33:09 +0000
Subject: [PATCH] Updated Find Bugs configuration

---
 .fbfilter.xml | 37 +++++++++++++++++++++++++++++++++++++
 .fbprefs      | 27 +++++++++++++++------------
 2 files changed, 52 insertions(+), 12 deletions(-)
 create mode 100644 .fbfilter.xml

diff --git a/.fbfilter.xml b/.fbfilter.xml
new file mode 100644
index 000000000000..25fa754f8760
--- /dev/null
+++ b/.fbfilter.xml
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+  <!-- Tests -->
+  <Match>
+    <Class name="~.*Test(\$[^\$]+)*"/>
+  </Match>
+  <!-- Generated code -->
+  <Match>
+    <Class name="~.*\.LocalTimeProtocol(\$[^\$]+)*"/>
+  </Match>
+  <!-- Noise -->
+  <Match>
+    <Bug code="Co,SF"
+         category="I18N"
+         pattern="REC_CATCH_EXCEPTION,UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR,DB_DUPLICATE_SWITCH_CLAUSES,VO_VOLATILE_REFERENCE_TO_ARRAY" />
+  </Match>
+  <!-- Known false positives -->
+  <Match>
+    <Class name="~.*Channel(Group)?Future"/>
+    <Method name="~await.*"/>
+    <Bug pattern="PS_PUBLIC_SEMAPHORES"/>
+  </Match>
+  <Match>
+    <Class name="~.*SelectorLoop"/>
+    <Method name="run"/>
+    <Bug code="ESync"/>
+  </Match>
+  <!-- Known issues that don't matter -->
+  <Match>
+    <Or>
+      <Class name="~.*\.util\.Concurrent[A-Za-z]*HashMap(\$[^\$]+)*"/>
+      <Class name="~.*\.util\..*TransferQueue(\$[^\$]+)*"/>
+      <Class name="~.*\.util\.MapBackedSet"/>
+    </Or>
+    <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED,SE_BAD_FIELD"/>
+  </Match>
+</FindBugsFilter>
diff --git a/.fbprefs b/.fbprefs
index 9956f008f781..f09dbd1bb03a 100644
--- a/.fbprefs
+++ b/.fbprefs
@@ -1,14 +1,14 @@
 #FindBugs User Preferences
-#Fri Feb 13 19:51:40 KST 2009
+#Wed Mar 04 19:28:55 KST 2009
 detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true
-detectorBCPMethodReturnCheck=BCPMethodReturnCheck|false
+detectorBCPMethodReturnCheck=BCPMethodReturnCheck|true
 detectorBadAppletConstructor=BadAppletConstructor|true
 detectorBadResultSetAccess=BadResultSetAccess|true
 detectorBadSyntaxForRegularExpression=BadSyntaxForRegularExpression|true
 detectorBadUseOfReturnValue=BadUseOfReturnValue|true
 detectorBadlyOverriddenAdapter=BadlyOverriddenAdapter|true
 detectorBooleanReturnNull=BooleanReturnNull|true
-detectorBuildInterproceduralCallGraph=BuildInterproceduralCallGraph|false
+detectorBuildInterproceduralCallGraph=BuildInterproceduralCallGraph|true
 detectorBuildObligationPolicyDatabase=BuildObligationPolicyDatabase|true
 detectorCallToUnsupportedMethod=CallToUnsupportedMethod|true
 detectorCalledMethods=CalledMethods|true
@@ -29,13 +29,13 @@ detectorDumbMethodInvocations=DumbMethodInvocations|true
 detectorDumbMethods=DumbMethods|true
 detectorDuplicateBranches=DuplicateBranches|true
 detectorEmptyZipFileEntry=EmptyZipFileEntry|true
-detectorEqStringTest=EqStringTest|false
+detectorEqStringTest=EqStringTest|true
 detectorEqualsOperandShouldHaveClassCompatibleWithThis=EqualsOperandShouldHaveClassCompatibleWithThis|true
 detectorFieldItemSummary=FieldItemSummary|true
 detectorFinalizerNullsFields=FinalizerNullsFields|true
-detectorFindBadCast=FindBadCast|false
+detectorFindBadCast=FindBadCast|true
 detectorFindBadCast2=FindBadCast2|true
-detectorFindBadEqualsImplementation=FindBadEqualsImplementation|false
+detectorFindBadEqualsImplementation=FindBadEqualsImplementation|true
 detectorFindBadForLoop=FindBadForLoop|true
 detectorFindBugsSummaryStats=FindBugsSummaryStats|true
 detectorFindCircularDependencies=FindCircularDependencies|false
@@ -94,13 +94,15 @@ detectorInvalidJUnitTest=InvalidJUnitTest|true
 detectorIteratorIdioms=IteratorIdioms|true
 detectorLazyInit=LazyInit|true
 detectorLoadOfKnownNullValue=LoadOfKnownNullValue|true
-detectorLockedFields=LockedFields|false
+detectorLockedFields=LockedFields|true
 detectorMethodReturnCheck=MethodReturnCheck|true
 detectorMethods=Methods|true
 detectorMultithreadedInstanceAccess=MultithreadedInstanceAccess|true
 detectorMutableLock=MutableLock|true
 detectorMutableStaticFields=MutableStaticFields|true
 detectorNaming=Naming|true
+detectorNoise=Noise|false
+detectorNoiseNullDeref=NoiseNullDeref|false
 detectorNoteAnnotationRetention=NoteAnnotationRetention|true
 detectorNoteCheckReturnValue=NoteCheckReturnValue|true
 detectorNoteCheckReturnValueAnnotations=NoteCheckReturnValueAnnotations|true
@@ -113,13 +115,13 @@ detectorNoteUnconditionalParamDerefs=NoteUnconditionalParamDerefs|true
 detectorNumberConstructor=NumberConstructor|true
 detectorOverridingEqualsNotSymmetrical=OverridingEqualsNotSymmetrical|true
 detectorPreferZeroLengthArrays=PreferZeroLengthArrays|true
-detectorPublicSemaphores=PublicSemaphores|false
+detectorPublicSemaphores=PublicSemaphores|true
 detectorQuestionableBooleanAssignment=QuestionableBooleanAssignment|true
 detectorReadReturnShouldBeChecked=ReadReturnShouldBeChecked|true
 detectorRedundantInterfaces=RedundantInterfaces|true
 detectorReflectiveClasses=ReflectiveClasses|true
 detectorRepeatedConditionals=RepeatedConditionals|true
-detectorResolveAllReferences=ResolveAllReferences|false
+detectorResolveAllReferences=ResolveAllReferences|true
 detectorRuntimeExceptionCapture=RuntimeExceptionCapture|true
 detectorSerializableIdiom=SerializableIdiom|true
 detectorStartInConstructor=StartInConstructor|true
@@ -149,8 +151,9 @@ detectorVolatileUsage=VolatileUsage|true
 detectorWaitInLoop=WaitInLoop|true
 detectorWrongMapIterator=WrongMapIterator|true
 detectorXMLFactoryBypass=XMLFactoryBypass|true
-detector_threshold=2
+detector_threshold=3
 effort=max
-filter_settings=Medium|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false
-filter_settings_neg=|
+excludefilter0=.fbfilter.xml
+filter_settings=Low|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false
+filter_settings_neg=NOISE|
 run_at_full_build=true