Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More modular unit testing #102

Open
jagerber48 opened this issue Jan 7, 2024 · 2 comments · Fixed by #161
Open

More modular unit testing #102

jagerber48 opened this issue Jan 7, 2024 · 2 comments · Fixed by #161

Comments

@jagerber48
Copy link
Owner

Many of the tests are more like integration than unit tests. While these are valuable and demonstrate good usage example, I think it would help the organization and usefulness of the tests if there were more modular unit tests. e.g. testing the functionality of the various formatting utilities, or the construction of format options classes from the FSML.

@jagerber48
Copy link
Owner Author

jagerber48 commented Feb 18, 2024

This issue begins to be addressed by #158 which sorts tests into unit tests and feature tests. That sorting revealed that almost all of the tests are feature tests. There is very little unit testing. This issue is a call for more unit testing.

@jagerber48 jagerber48 linked a pull request Feb 18, 2024 that will close this issue
@jagerber48
Copy link
Owner Author

More unit tests can still be added after #161

@jagerber48 jagerber48 reopened this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant