Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding configuration #185

Open
jagerber48 opened this issue Aug 14, 2024 · 0 comments · May be fixed by #187
Open

Rounding configuration #185

jagerber48 opened this issue Aug 14, 2024 · 0 comments · May be fixed by #187

Comments

@jagerber48
Copy link
Owner

Recently ndigits was changed to have an "all" and "pdg" mode. An alternative was to have these two options be on round_mode, I think this latter would be more natural. I chose the former in anticipation of the resolution to #177 where I thought users might specify a fallback_ndigits to use for the value when the uncertainty is invalid. Doing it this way gives users a little more control on the fallback. But I realized users could have FULL control over the fallback if they just provide an additional formatter. This pollutes the option space even less in my opinion. Because of this I think the all and pdg options should be moved into round_mode with ndigits always being an integer and only used in sig_fig and dec_place modes.

@jagerber48 jagerber48 linked a pull request Aug 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant