Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futures ETHUSDT market has an issue in JSON.parse #539

Open
wwforever opened this issue Dec 14, 2020 · 8 comments
Open

Futures ETHUSDT market has an issue in JSON.parse #539

wwforever opened this issue Dec 14, 2020 · 8 comments
Labels
help wanted needs-testing Someone else please confirm this bug and it will be fixed

Comments

@wwforever
Copy link

wwforever commented Dec 14, 2020

Futures ETHUSDT market has an issue in JSON.parse (I don't know if it occurs in Spot or Coin-m, etc.)

The order id value of Ethereum has been changed from Number to Bigint.
It seems to have occurred around December 9, 2020. It is believed that the issue occurred after Binance supported Ethereum 2.0 staking.

I solved it using JSON-bigint.
https://github.com/sidorares/json-bigint

Change JSON.parse to JSONbig.parse in line 182 reqHandler function.
Change JSON.parse to JSONbig.parse.In line 509 promiseRequest function.

@jaggedsoft
Copy link
Owner

Thank you very much!
40f3da3

@kalinbas
Copy link
Contributor

This should be changed anywhere (e.g. also in WS Streams). Another issue here is that when I have a BigNumber OrderId and want to call CancelOrder with it, can i be sure it is serialized in the correct way?

@jaggedsoft
Copy link
Owner

these were all strings in the past if i remember correctly

@jaggedsoft jaggedsoft added help wanted needs-testing Someone else please confirm this bug and it will be fixed labels Dec 23, 2020
@jaggedsoft jaggedsoft reopened this Dec 23, 2020
@Kuzmich100kM
Copy link

Help me plz.
At futures ETHUSDT market function order_update_callback return orderId like here

изображение

But the real orderId is

изображение

@c0sm1cdus7
Copy link

c0sm1cdus7 commented Dec 17, 2021

@jaggedsoft

Did you manage to fix this?

@doppelgunner
Copy link

@jaggedsoft please fix this

@doppelgunner
Copy link

I already made PR for this @jaggedsoft

Please merge:
#890

@doppelgunner
Copy link

In themeantime i created node-binance-api-2 so that you can use this while the PR #890 is not merged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted needs-testing Someone else please confirm this bug and it will be fixed
Projects
None yet
Development

No branches or pull requests

6 participants