-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Futures ETHUSDT market has an issue in JSON.parse #539
Comments
Thank you very much! |
This should be changed anywhere (e.g. also in WS Streams). Another issue here is that when I have a BigNumber OrderId and want to call CancelOrder with it, can i be sure it is serialized in the correct way? |
these were all strings in the past if i remember correctly |
Did you manage to fix this? |
@jaggedsoft please fix this |
I already made PR for this @jaggedsoft Please merge: |
In themeantime i created node-binance-api-2 so that you can use this while the PR #890 is not merged: |
Futures ETHUSDT market has an issue in JSON.parse (I don't know if it occurs in Spot or Coin-m, etc.)
The order id value of Ethereum has been changed from Number to Bigint.
It seems to have occurred around December 9, 2020. It is believed that the issue occurred after Binance supported Ethereum 2.0 staking.
I solved it using JSON-bigint.
https://github.com/sidorares/json-bigint
Change JSON.parse to JSONbig.parse in line 182 reqHandler function.
Change JSON.parse to JSONbig.parse.In line 509 promiseRequest function.
The text was updated successfully, but these errors were encountered: