Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release]: 3.0.4 service release #374

Closed
17 tasks done
KyleAure opened this issue Nov 9, 2023 · 5 comments · Fixed by jakartaee/specifications#756
Closed
17 tasks done

[Release]: 3.0.4 service release #374

KyleAure opened this issue Nov 9, 2023 · 5 comments · Fixed by jakartaee/specifications#756
Assignees

Comments

@KyleAure
Copy link
Contributor

KyleAure commented Nov 9, 2023

Proposal

If we were to create a 3.0.4 service release I wanted an issue open to track changes we would want to put in

Outstanding work

Check List

Prepare

  • Open this issue.
  • Complete outstanding work
  • (Update TCK Signatures to capture API changes)[https://github.com/jakartaee/concurrency/actions/workflows/release.yml]

Stage release

Verify and modify

  • Ask for feedback from the community to verify the staged artifact has all the expected changes.
  • If anything needs to be added before publishing do that now and repeat the Stage Release section

Publish release

Follow up

@KyleAure KyleAure self-assigned this Dec 26, 2023
@KyleAure KyleAure changed the title Tracking issues for possible 3.0.4 service release [Release]: 3.0.4 service release Mar 18, 2024
@KyleAure
Copy link
Contributor Author

KyleAure commented Jun 28, 2024

3.0.4 is Staged

Verification Data

file sha256
concurrency-tck-3.0.4.zip aa29bfc0bab42d9aa2da518208d9e92cdde80fc17b00dd658954dfd36064a426

@scottmarlow can you test this staged TCK with Wildfly and let me know if there are any other changes you need in this service release. Once I hear back from you I'll go ahead with a publishing this.

@jamezp
Copy link
Contributor

jamezp commented Jun 28, 2024

This is passing on WildFly. One important thing to note here is there is a requirement to use jakarta.tck:sigtest-maven-plugin:2.3 here. Older versions will not work because of the change to -IgnoreJDKClass.

OT: I'm working with @scottmarlow to somewhat revert this. IoW revert the -IgnoreJDKClass to work as it did before and add a -IgnoreJDKClasses argument instead. See eclipse-ee4j/jakartaee-tck-tools#39

@KyleAure
Copy link
Contributor Author

KyleAure commented Jun 28, 2024

@jamezp I did update the TCK Distribution user guide which says:

1. **Signature Test Tool** - No action is needed here, but we note that the signature files were built and should be validated with the Maven plugin with group:artifact:version coordinates: **{SigPluginGAV}**, as used by the sample sigtest runner included in the TCK zip. This is a more specific direction than in earlier releases, in which it was left more open for the user to use a compatible tool. Since there are small differences in the various signature test tools, we standardize on this version.

As mentioned in the prerequisite section the signature file formats across the various signature test tools have diverged and this test suite uses the Maven plugin with group:artifact:version coordinates: **{SigPluginGAV}**.

So it should be clear that users need to use specifically the 2.3 version of the plugin.
If you think anymore documentation should be added let me know. Otherwise, I'll go forward with releasing this.

@jamezp
Copy link
Contributor

jamezp commented Jun 28, 2024

@KyleAure No, I think that is sufficient. We were using a very old version anyway :) I say go forward with the release.

@KyleAure
Copy link
Contributor Author

3.0.4 is Released

Verification Data

file sha256
concurrency-tck-3.0.4.zip aa29bfc0bab42d9aa2da518208d9e92cdde80fc17b00dd658954dfd36064a426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants