Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate requirements around the keywords properties file #1428

Open
starksm64 opened this issue Jul 31, 2024 · 1 comment
Open

Investigate requirements around the keywords properties file #1428

starksm64 opened this issue Jul 31, 2024 · 1 comment
Assignees

Comments

@starksm64
Copy link
Contributor

starksm64 commented Jul 31, 2024

There is a src/com/sun/ts/lib/harness/keyword.properties that looks to funtion somewhat like Junit5 Tags, but applies to a package level. In the com.sun.ts.lib.harness classes, it looks like the only place this is really used is in the com.sun.ts.lib.harness.TSTestFinder which is extends a JavaTest class, so it does not look like the keywords passed to the EETest and ServiceEETest entry points actually affect which tests are run unless JavaTest is being used.

The issue would be to create Junit5 Tag entries at the test class level in the event that we want to use the keyword filtering capability.

@starksm64 starksm64 self-assigned this Jul 31, 2024
starksm64 added a commit to jakartaredhat/jakartaee-tck-tools that referenced this issue Aug 1, 2024
@starksm64
Copy link
Contributor Author

One subtask left is to update the keywords to use tag names consistent with other specs. Jakarta Data uses:

@tag("persistence")
@tag("core")
@tag("web")
@tag("platform")
@tag("signature")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

No branches or pull requests

1 participant