-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core profile CDI tests use archive without beans.xml #1526
Comments
I don't know the precise reason why and how they passed but EE implementations can mark deployment as CDI ones (meaning they will trigger Weld startup) based on various other indicators than just beans.xml presence. But it is just a guess. Either way, there should IMO be |
@manovotn & @Ladicek For now I've added the following to the test runner, but I guess you meant the latter option? public class CustomJsonbSerializationITFix implements LoadableExtension {
@Override
public void register(ExtensionBuilder builder) {
builder.observer(CustomJsonbSerializationITFix.class);
}
public void removeService(@Observes BeforeDeploy event) {
Archive<?> archive = event.getDeployment().getArchive();
if (archive instanceof WebArchive webArchive) {
if (webArchive.getName().equals("CustomJsonbSerializationIT.war")) {
webArchive.addAsWebInfResource(EmptyAsset.INSTANCE, "beans.xml");
}
}
}
} |
I mean I'd add |
The test ee.jakarta.tck.core.rest.jsonb.cdi.CustomJsonbSerializationIT in the 10.0.3 core profile TCK creates the following archive:
According to https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0#bean_archive the beans.xml file is required.
How are we supposed to pass this, or did I interpret something incorrectly? A number of products have already passed the Core TCK, so I'm not entirely sure what I'm missing, if anything.
The text was updated successfully, but these errors were encountered: