Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I found errors while translating #79

Open
ghost opened this issue Dec 4, 2019 · 0 comments
Open

I found errors while translating #79

ghost opened this issue Dec 4, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Dec 4, 2019

Before begin, I'm really sorry that I translated your code into Korean without your permissions.

I found some errors in your codes. Firstly, in ko_chance.js, the 'burned' damage is counted as 1/8 of max. HP, not 1/16 max. HP. Also there's no move data of Mystical Flame. In pokedex.js fixed Aegislash data in 8th gen is wrong. You used atk, def not at, df. Also in setdex_tt2020.js, There's no Pressure ability data in ability_data.js

I hope it'll be fixed and I'll tell you when I found more problems. Thanks for your work!
ProfessorSidon added a commit to ProfessorSidon/VGC-Damage-Calculator that referenced this issue Dec 18, 2019
@ProfessorSidon
Fix burn damage
8740345 
Burn damage is reduced to 1/16 of HP from generation 7 onward.
Mentioned in issue jake-white#79

Signed-off-by: ProfessorSidon <[email protected]>
@ProfessorSidon ProfessorSidon mentioned this issue Dec 18, 2019
Merged
ProfessorSidon added a commit to ProfessorSidon/VGC-Damage-Calculator that referenced this issue Dec 18, 2019
@ProfessorSidon
Fix Aegislash stat in Gen8
3451e5d 
Mentioned in issue jake-white#79
@ProfessorSidon ProfessorSidon mentioned this issue Dec 18, 2019
Merged
ProfessorSidon added a commit to ProfessorSidon/VGC-Damage-Calculator that referenced this issue Dec 18, 2019
@ProfessorSidon
Fix burn damage
977c2c4 
Burn damage is reduced to 1/16 of HP from generation 7 onward.
Mentioned in issue jake-white#79

Signed-off-by: ProfessorSidon <[email protected]>
ProfessorSidon added a commit to ProfessorSidon/VGC-Damage-Calculator that referenced this issue Dec 18, 2019
@ProfessorSidon
Fix Aegislash stat in Gen8
072164f 
Mentioned in issue jake-white#79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants