Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it seems that this new version is true and old not #3

Closed
wants to merge 1 commit into from

Conversation

matkoniecz
Copy link

fixes #2

Tested for me, but maybe I screwed something up or should do it differently?

@matkoniecz
Copy link
Author

matkoniecz commented Apr 11, 2021

I would be happy to learn why and how I am wrong here.

Is there a chance that fact that my .bashrc is a symbolic link to repo with my dotfiles may be breaking something? (for reference: https://github.com/matkoniecz/my_public_dotfiles )

@jakub-g
Copy link
Owner

jakub-g commented Apr 12, 2021

Hi, thx for the PR!

I agree the instructions are not very clear/thorough.

In fact the command without - i.e. git something works for me, but I'm based on Windows (using git bash), but it's not trivial how it's supposed to work.

There's some built-in mechanism in git that if you run git something it will run git-something script. This script must be in $PATH and be executable:

https://blog.dreamfactory.com/extending-git-with-a-custom-command/

So you'd need to chmod u+x the new file if you copy it somewhere.

If you just copy a bash function directly to your .bashrc, you'd have to reload your terminal session (and perhaps something more).

@jakub-g
Copy link
Owner

jakub-g commented Apr 12, 2021

In addition to last statement, on my side I put helpers not into .bashrc anymore but into .profile. Whenever I change something, I have to source ~/.profile to have my shell reloaded with the newly added things.

@matkoniecz
Copy link
Author

not sure what went wrong here, I admit that I have not time to investigate that

@matkoniecz matkoniecz closed this Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation istructions fail - at least for confused people like me
2 participants