Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use VALVE #22

Open
jamesaoverton opened this issue Jan 26, 2021 · 8 comments
Open

Update to use VALVE #22

jamesaoverton opened this issue Jan 26, 2021 · 8 comments

Comments

@jamesaoverton
Copy link
Owner

I would like to add examples, terminology browser, and validation form for cell names and markers using VALVE, following the model of the extended immune exposure site:

I've done preliminary work on a Google Sheet here:

https://docs.google.com/spreadsheets/d/109FaxCDuwj9fxPqk1_haIrwo3_Y6EPU8lbNGYzmbRsU/edit#gid=0

I also have some data and scripts that I will shared.

@jamesaoverton
Copy link
Owner Author

jamesaoverton commented Jan 27, 2021

Looking around at the code here and locally, we need to take a step back.

  1. add a simplified table of "special_markers" from here to the new Google Sheet here
  2. generate a table of all valid markers (with columns: ID, Name) from three sources
    • special_markers
    • Protein Ontology labels and exact synonyms
  3. generate a table of cell names (with columns: ID, Name) from Cell Ontology labels and synonyms
  4. finish the VALVE configuration tables
  5. test on three datasets (emailed): HIPC, IMPACC, LJI
  6. update the interesting ontological code here to connect to VALVE
  7. then start working on a new website

The tables from 2 and maybe 3 will be too large to fit in a Google Sheet, so we need tasks in the Makefile to build them locally or on DROID. The current Makefile and src/ have code for this but I think we should write new code to use RDFTab.

@beckyjackson
Copy link
Collaborator

beckyjackson commented Jan 27, 2021

add a simplified table of "special_markers" from here to the new Google Sheet here

Does "special_markers" correspond with "Special Gates" of the first Google Sheet? Or is it a combination of sheets?

@jamesaoverton
Copy link
Owner Author

Yes, "Special Gates", but we probably don't need all the columns.

@beckyjackson
Copy link
Collaborator

Do you think we only need ID & Label?

@jamesaoverton
Copy link
Owner Author

We need IDs and synonyms for now, so I edited to say "ID and Name" columns.

@beckyjackson
Copy link
Collaborator

beckyjackson commented Jan 27, 2021

For tracking:

  • add a simplified table of "special_markers"
  • generate a table of all valid markers (with columns: ID, Name) from three sources (special_markers, PR labels, PR synonyms)
  • generate a table of cell names (with columns: ID, Name) from Cell Ontology labels and synonyms
  • finish the VALVE configuration tables
  • test on three datasets (emailed): HIPC, IMPACC, LJI
  • update the interesting ontological code here to connect to VALVE

@beckyjackson
Copy link
Collaborator

update the interesting ontological code here to connect to VALVE

Was this supposed to be a link? Or just the code in this repo?

@jamesaoverton
Copy link
Owner Author

The code in this repo which compares gating definitions to Cell Ontology logical axioms, making up most of the content of the current web pages. This is what I'm thinking of:

https://github.com/jamesaoverton/cell-name-and-marker-validator/blob/master/src/server.py#L229

It would be better to talk about this on a call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants