Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for assert statements in Arrange block #147

Open
4 tasks
jamescooke opened this issue May 3, 2020 · 0 comments
Open
4 tasks

Check for assert statements in Arrange block #147

jamescooke opened this issue May 3, 2020 · 0 comments
Labels
type:feature New feature or request
Milestone
v1.stable

Comments

@jamescooke
Copy link
Owner

Ensure that assertions are not carried out in the Arrange block - a smell that arrangement is too complicated.

  • Add bad examples.

  • Update documentation with new error code: "Problematic code", "Correct code", "Rationale", "Exceptions"

  • Update CHANGELOG

  • Extra: Add example of assert and self.assertEqual() in Act with statement body. This pins this responsibility on the context manager analysis that happens when the Act block is built.
@jamescooke jamescooke added this to the v1.0.0 milestone May 3, 2020
@jamescooke jamescooke added the type:feature New feature or request label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature New feature or request
Projects
None yet
Milestone
v1.stable
Development

No branches or pull requests
1 participant
@jamescooke