Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of protected instead of private function #58

Open
oza75 opened this issue Dec 11, 2020 · 2 comments
Open

Usage of protected instead of private function #58

oza75 opened this issue Dec 11, 2020 · 2 comments
Labels
question Further information is requested

Comments

@oza75
Copy link

oza75 commented Dec 11, 2020

private function formatTimezone(Carbon $date) : string

I'm wondering, if we can use protected instead of private function then people can easily extends the Timezone and customize to their need.

Also, Can we extract the obtaining of the time zone in another class which will be responsible for assigning the time zone to the user (the user could be passed in the constructor and if not then we will use the Auth::user() )?

This will allow us to assign the time zone to the user without necessarily listening to the authentication event.

$ip = $this->getFromLookup();

@jamesmills
Copy link
Owner

I'm wondering, if we can use protected instead of private function then people can easily extends the Timezone and customize to their need.

@oza75 do you still require this?

@jamesmills
Copy link
Owner

Can we extract the obtaining of the time zone in another class which will be responsible for assigning the time zone to the user

@oza75 I'm wondering if this #36 is going to help with that? It's still being worked on but I think we will release an update soon.

@jamesmills jamesmills added the question Further information is requested label Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants