Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating wrong timezone automatically add manual feature #77

Open
thedevsbuddy opened this issue Dec 31, 2021 · 4 comments
Open

Updating wrong timezone automatically add manual feature #77

thedevsbuddy opened this issue Dec 31, 2021 · 4 comments

Comments

@thedevsbuddy
Copy link

Please add a feature to stop updating timezone automatically and let the user set their timezone manually if they want. because if we are logging in every time it is setting the timezone which is wrong.

@boryn
Copy link

boryn commented Jan 18, 2022

There is already this option in timezone.php, use 'overwrite' => false,.

Setting the timezone manually is, IMHO out of scope of this library. You should implement it by yourself e.g. in the user profile settings.

@hyphen81
Copy link

hyphen81 commented Apr 9, 2023

I'm experiencing this issue as well and wondering why it's not correctly identifying the timezone? Is that an issue with the underlying geoip package or what? I'm in America/Chicago and it keeps changing it to America/New_York. I guess I'll just set the overwrite to false and manage it in my app, but I liked the idea of it identifying it.

@hyphen81
Copy link

hyphen81 commented Apr 9, 2023

I would also say, that I just happened to stumble upon this issue and realized the timezone is not reliably identified. With the near PTSD level trauma I have from dealing with timezones, this could really contribute to a lot of mental breakdowns among users of this package. (I'm being hyperbolic of course). But I would never go back and check the timezone to make sure it didn't change, when I initially set it to the correct one. What I'm getting at, is maybe setting overwrite to false as the default, or putting some notes in the docs about this behavior. I apologize if it's already in the docs, but I don't recall seeing anything about it. Granted I didn't go so deep as to read the docs for the underlying geoip package, so ignore me if I'm just an ignorant fool, spouting off on the internet. Just my humble thoughts.

Also, great package, thank you very much for this. It's a lifesaver.

@hyphen81
Copy link

To anyone else that might be dumb like me....just took a peak at the geoip config file and it has a default location for localhost, which is set to America/New_York, hence why it was updating mine incorrectly. After changing the config setting in geoip config, it's working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants