-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PaaS manifest handling #172
Comments
I tested it on the hosted server. Where do you get the dictionary response
from? Local planutils? I did not test that. Thought they were just two
packaging's of the same service.
J
…On Wed, Nov 8, 2023, 17:38 Christian Muise ***@***.***> wrote:
This change seems to have caused a regression with the proper server setup:
0a973a1
#diff-aa76e7a01629cf47157ed907a2b25bc125e8ed91d2992b3c881df6a9208ea66fR28
<0a973a1#diff-aa76e7a01629cf47157ed907a2b25bc125e8ed91d2992b3c881df6a9208ea66fR28>
The latest uses a dict setup for the manifest, rather than a list:
https://github.com/AI-Planning/planning-as-a-service/blob/main/server/api/app.py#L161
—
Reply to this email directly, view it on GitHub
<#172>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2JYHLDRXTBKA4ACJ7HRGDYDOYP3AVCNFSM6AAAAAA7DFZW2SVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DGOJZG42TSMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Aye, the deployed one was on a stale branch, but was fixed. Should be showing a mapping now as well: https://paas-uom.org:5001/package |
Got it. Found it. Reverted the manifest json parsing. Deploying soon.
While testing, I am running into this awkward behavior. The first package
in the list is "Delfi". But selecting that returns
HTTP 200
content type plain/text
Body: Error: This Planutils package is not configured correctly
This fails in the library that is parsing the response and is expecting
application/json type when the status code is 200.
Can the response HTTP status be set to 500? Or possibly 418, but this is
not something the user can fix on the client side.
…On Thu, Nov 9, 2023 at 1:53 AM Christian Muise ***@***.***> wrote:
Aye, the deployed one was on a stale branch, but was fixed. Should be
showing a mapping now as well: https://paas-uom.org:5001/package
—
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2JYHI4QSO3DRKVZY7ID53YDQSP7AVCNFSM6AAAAAA7DFZW2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSHE4TGOBTGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
The offending line: https://github.com/AI-Planning/planning-as-a-service/blob/main/server/api/app.py#L60 This fix ok by you, @jan-dolejsi ? |
Thank you for the quick fix, btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This change seems to have caused a regression with the proper server setup:
0a973a1#diff-aa76e7a01629cf47157ed907a2b25bc125e8ed91d2992b3c881df6a9208ea66fR28
The latest uses a dict setup for the manifest, rather than a list:
https://github.com/AI-Planning/planning-as-a-service/blob/main/server/api/app.py#L161
The text was updated successfully, but these errors were encountered: