Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Switch to RepoUrlPicker to fill repository information #166

Open
schultzp2020 opened this issue Aug 23, 2023 · 2 comments
Open

Switch to RepoUrlPicker to fill repository information #166

schultzp2020 opened this issue Aug 23, 2023 · 2 comments

Comments

@schultzp2020
Copy link
Member

The RepoUrlPicker will automatically ask the corresponding information for each type of repository.

e.g. https://github.com/backstage/software-templates/blob/main/scaffolder-templates/react-ssr-template/template.yaml#L43

@Zaperex
Copy link
Member

Zaperex commented Sep 15, 2023

The main issue I've found with the RepoUrlPicker at the moment is that the allowedHosts only supports a list of hardcoded host urls in the template. So if the user wants to use a private host instance, they'll need to directly modify the template to include them, and refresh/re-ingest them.

Leaving the allowedHosts field blank, or not providing it causes the allow list to default to [] meaning nothing is allowed.

@schultzp2020
Copy link
Member Author

So if the user wants to use a private host instance, they'll need to directly modify the template to include them, and refresh/re-ingest them.

@Zaperex that is ok because we expect the users to modify the templates. For now lets hold off on this issue because RepoUrlPicker is still missing some key features.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants