Skip to content

chore: add missing entries to .gitignore#9

Merged
janx merged 1 commit into
mainfrom
chore/update-gitignore
Apr 16, 2026
Merged

chore: add missing entries to .gitignore#9
janx merged 1 commit into
mainfrom
chore/update-gitignore

Conversation

@poshboytl

@poshboytl poshboytl commented Apr 13, 2026

Copy link
Copy Markdown
Contributor
  • Add 5 missing entries to .gitignore: ckbadger.toml, data/, dob_decode/, mise.toml, perf/
  • These are local runtime artifacts and personal config that should not be tracked

Local runtime artifacts were not ignored: ckbadger.toml, data/,
dob_decode/, mise.toml, perf/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@janx

janx commented Apr 16, 2026

Copy link
Copy Markdown
Owner

These files are created in repo because you didn't specify a workdir explicitly (with -C). It's better to use a different workdir than the repo dir.

@janx janx closed this Apr 16, 2026
@janx

janx commented Apr 16, 2026

Copy link
Copy Markdown
Owner

A second thought: adding these entries to .gitignore brings no hurts. @claude what do you think?

@claude

claude Bot commented Apr 16, 2026

Copy link
Copy Markdown

Claude finished @janx's task in 50s —— View job


Analysis

  • Read .gitignore and PR changes
  • Analyze whether the additions make sense

I agree — adding these entries is harmless and actually a good idea. Here's my take on each:

Entry Verdict Reasoning
ckbadger.toml ✅ Add Personal/local config, same class as .env (already ignored). Paths inside are machine-specific.
data/ ✅ Add RocksDB data — could be hundreds of GB of binary files. Accidentally committing this would be catastrophic. Deserves explicit protection.
dob_decode/ ✅ Add Runtime artifact, has no place in version control.
mise.toml ✅ Add Developer toolchain config (personal). This project doesn't commit one, so ignoring local copies is correct.
perf/ ✅ Add Performance benchmark output. Should not be tracked.

The "use -C to specify workdir" advice is correct best practice, but these two approaches are complementary, not mutually exclusive. The .gitignore entries serve as a safety net for developers who:

  • Don't know about the -C convention
  • Run quick one-off commands from the repo root
  • Have tooling that doesn't pass through the workdir flag

The cost is 11 lines in .gitignore. The benefit is preventing accidental commits of binary databases, personal configs, and large runtime artifacts. I'd reopen or re-apply this PR.


@janx janx reopened this Apr 16, 2026
@janx janx merged commit 77574e5 into main Apr 16, 2026
7 checks passed
@janx janx deleted the chore/update-gitignore branch April 16, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants