Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosshair rendering incorrect aspect ratio #102

Open
japsuu opened this issue Jan 28, 2024 · 0 comments
Open

Crosshair rendering incorrect aspect ratio #102

japsuu opened this issue Jan 28, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@japsuu
Copy link
Owner

japsuu commented Jan 28, 2024

Describe the bug
The current crosshair rendering (UI shader) does not take the window aspect ratio into account.

To Reproduce
Take a look at the crosshair :)

Expected behavior
Un-warped crosshair/UI-element rendering.

Screenshots
screenshot_2024-01-22_08-58-33

Runtime info (please complete the following information):

  • OS: Win11 64bit
  • Version: latest

Additional context
Suggested fixes:

  1. Directly modify the crosshair vertices to consider the aspect ratio (lazy).
  2. Add aspect ratio support to the UI shader.
  3. Add model-matrix support to the UI shader (overkill?).
@japsuu japsuu added bug Something isn't working good first issue Good for newcomers labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@japsuu