Fix: Duplicate Order values when adding new columns

[jas88]

Problem

When adding a new TableColumn/ExtractionInformation, the Order property defaults to 1 instead of automatically selecting the next available non-conflicting value, causing duplicate order IDs.

Current Behavior

New columns are created with Order = 1, resulting in:

• Multiple columns with the same order value
• Undefined/inconsistent column ordering in UI and queries
• Potential data integrity issues

Expected Behavior

When creating a new column, the Order value should be automatically set to:

Order = existingColumns.Max(c => c.Order) + 1

Or if no existing columns: Order = 1

Impact

This is a data integrity bug that affects:

• Column display order in UI
• Export column ordering
• Query result consistency

Related Files

Likely needs fixes in:

• Rdmp.Core/Curation/Data/ColumnInfo.cs - Constructor/initialization
• Rdmp.Core/Curation/Data/ExtractionInformation.cs - Constructor/initialization
• Any repository methods that create new columns

Upstream Reference

Originally reported in HicServices/RDMP#1592

To Reproduce

1. Create a catalogue with columns
2. Add a new column through the UI or API
3. Observe that new column has Order = 1 conflicting with existing column

Suggested Fix

In column creation logic, query existing columns and auto-assign next order:

// When creating new column
var maxOrder = existingColumns.Any() ? existingColumns.Max(c => c.Order) : 0;
newColumn.Order = maxOrder + 1;

[jas88]

Analysis

Upon code review, ExtractionInformation already has proper Order assignment via the GetMaxOrder() method (lines 153-168 in ExtractionInformation.cs):

private static int GetMaxOrder(CatalogueItem catalogueItem)
{
    try
    {
        var cata = catalogueItem.Catalogue;
        cata.ClearAllInjections();
        var eiMax = cata.GetAllExtractionInformation(ExtractionCategory.Any).MaxBy(ei => ei.Order);
        return eiMax == null ? 1 : eiMax.Order + 1;
    }
    catch (Exception)
    {
        return 1;
    }
}

This is called from the constructor (line 133) when creating new ExtractionInformation objects.

Questions to investigate:

1. Is there another code path that creates ExtractionInformation without going through this constructor?
2. Is the issue actually about ExtractableColumn (which takes Order as a parameter) rather than ExtractionInformation?
3. Could this issue have been fixed in a more recent version?

If the issue persists, it may be in a different code path or the related files mentioned in the issue. Please provide reproduction steps with the current codebase to verify.