Skip to content

Please let me know if you would like to review pull requests #3014

@jgonggrijp

Description

@jgonggrijp

I copied this text from jashkenas/backbone#4268, so if you recognize it, that is not a coincidence.

I have taken on the burden of maintaining Underscore. I also happen to believe that ideally, each code change should be reviewed by somebody other than the author.

When somebody else submits a pull request (please do!), I can obviously review it. When I submit a pull request myself (which I do a lot), it is not so obvious who might review it.

So far, I've been blindly @mentioning people who I thought (or hoped) might be interested in reviewing. I now feel that this pattern is not sustainable; I will miss people who are interested and annoy people who are not. Instead, I would like to actually know which people are interested in reviewing.

Of course, I'm hoping that expert contributors are interested, but non-expert reviewers are welcome, too. The more reviewers, the better.

  • If you are interested in reviewing and you are already watching the repo so you will be aware of new pull requests, please leave a 👀.
  • If you are interested in reviewing and you would like to be @mentioned to draw your attention, leave a 🚀.
  • If you welcome formal review requests (so you see "review requested" in your GitHub notifications), leave a ❤️. If you opt-in for this, please also leave a comment to let me know what you consider an acceptable frequency and how quickly you expect to be able to respond (on average).
  • If you just feel like voting, leave a 👍.

Text replies for other reasons also welcome, of course.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionstartergood choice for new contributors

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions