Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate peerDependencies of the library #7

Open
lwouis opened this issue Apr 27, 2018 · 0 comments
Open

Validate peerDependencies of the library #7

lwouis opened this issue Apr 27, 2018 · 0 comments

Comments

@lwouis
Copy link

lwouis commented Apr 27, 2018

Hi,

It may be more a question that an issue, maybe I missed something. It seems to me that the library and the "demo" app (i.e. the app listing the lib in its own package.json) shouldn't be sharing all the dependencies in node_modules.

Currently it seems to me that there is no validation of the library's peerDependencies. A build can work for this repo, but then if the lib gets published, and another project add it to its dependencies, it will only get notified of some peerDependencies like @angular/common/@angular/core in your case.

If the lib itself has external dependencies, nothing makes sure to add those to the delivered package.json. You have to manually check what's needed and add it to the library's peerDependencies.

Am I missing something or is this process currently manual/unsafe?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant