Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker supplied tini #51

Open
daniel-noland opened this issue Oct 3, 2022 · 1 comment
Open

Use docker supplied tini #51

daniel-noland opened this issue Oct 3, 2022 · 1 comment

Comments

@daniel-noland
Copy link
Contributor

Noticed this while I was tidying up the code (I'm not trying to be nitpicky, just trying to get familiar with this code base because I plan to use it as a dependency for another project soon and I want to make sure I understand how it works).

rudolfs/Dockerfile

Lines 13 to 19 in 9f2eaad

# Use Tini as our PID 1. This will enable signals to be handled more correctly.
#
# Note that this can't be downloaded inside the scratch container as we have no
# chmod command.
#
# TODO: Use `--init` instead when it is more well-supported (this should be the
# case by Jan 1, 2020).

I was going to take care of this if it is still desirable in your view @jasonwhite

I have a PR ready but it is based on top of #46 so I'll just post the PR as draft till that is merged. No need for more merge resolution noise 😄

@jasonwhite
Copy link
Owner

Yes, this change would be very welcome! I expect most distros will have a relatively recent version of Docker with the --init option now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants