Skip to content

Commit 2c4d17b

Browse files
committed
update levels property whenever workspace emptyvalues change
1 parent 2d54908 commit 2c4d17b

File tree

5 files changed

+8
-0
lines changed

5 files changed

+8
-0
lines changed

CommonData/dataset.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,8 @@ void DataSet::setEmptyValuesJson(const Json::Value &emptyValues, bool updateDB)
563563
void DataSet::setWorkspaceEmptyValues(const stringset &values)
564564
{
565565
_emptyValues->setEmptyValues(values);
566+
for(Column * column : _columns)
567+
column->labelsTempReset();
566568
dbUpdate();
567569
}
568570

Desktop/data/columnsmodel.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,11 @@ ColumnsModel::ColumnsModel(DataSetTableModel *tableModel)
1616
connect(_tableModel, &DataSetTableModel::columnTypeChanged, this, [&](QString col, int) { emit columnTypeChanged(col); });
1717
connect(_tableModel, &DataSetTableModel::labelChanged, this, [&](QString col, QString orgLabel, QString newLabel) { emit labelsChanged(col, {std::make_pair(orgLabel, newLabel) }); } );
1818
connect(_tableModel, &DataSetTableModel::labelsReordered, this, &ColumnsModel::labelsReordered );
19+
connect(_tableModel, &DataSetTableModel::emptyValuesChanged, this, &ColumnsModel::dataSetChanged );
1920

2021
auto * info = new VariableInfo(_singleton);
2122

23+
2224
connect(this, &ColumnsModel::namesChanged, info, &VariableInfo::namesChanged );
2325
connect(this, &ColumnsModel::columnsChanged, info, &VariableInfo::columnsChanged );
2426
connect(this, &ColumnsModel::columnTypeChanged, info, &VariableInfo::columnTypeChanged );

Desktop/data/datasettablemodel.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ DataSetTableModel::DataSetTableModel(bool showInactive)
2828
connect(DataSetPackage::pkg(), &DataSetPackage::columnDataTypeChanged, this, [&](QString colName) { emit columnTypeChanged(colName, int(DataSetPackage::pkg()->getColumnType(colName))); }, Qt::QueuedConnection);
2929
connect(DataSetPackage::pkg(), &DataSetPackage::labelChanged, this, &DataSetTableModel::labelChanged );
3030
connect(DataSetPackage::pkg(), &DataSetPackage::labelsReordered, this, &DataSetTableModel::labelsReordered );
31+
connect(DataSetPackage::pkg(), &DataSetPackage::workspaceEmptyValuesChanged, this, &DataSetTableModel::emptyValuesChanged );
3132
//connect(this, &DataSetTableModel::dataChanged, this, &DataSetTableModel::onDataChanged, Qt::QueuedConnection);
3233

3334
setFilterRole(int(DataSetPackage::specialRoles::filter));

Desktop/data/datasettablemodel.h

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ class DataSetTableModel : public DataSetTableProxy
5757
void columnTypeChanged(QString colName, int colType);
5858
void labelChanged(QString columnName, QString originalLabel, QString newLabel);
5959
void labelsReordered(QString columnName);
60+
void emptyValuesChanged();
6061

6162
void renameColumnDialog(int columnIndex);
6263

QMLComponents/controls/variableslistbase.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ VariablesListBase::VariablesListBase(QQuickItem* parent)
4545
_controlType = ControlType::VariablesListView;
4646
_useControlMouseArea = false;
4747
_allowedTypesModel = new ColumnTypesModel(this);
48+
49+
connect(VariableInfo::info(), &VariableInfo::dataSetChanged, this, &VariablesListBase::levelsChanged);
4850
}
4951

5052
void VariablesListBase::setUp()

0 commit comments

Comments
 (0)