Stop infinite loop

fixes jasp-stats/jasp-test-release#2478

Author: JorisGoosen

Desktop/analysis/analysis.cpp

@@ -518,13 +518,18 @@ performType Analysis::desiredPerformTypeFromAnalysisStatus() const
 	}
 }
 
-std::set<std::string> Analysis::usedVariables()
+stringset Analysis::usedVariables()
 {
 	if (form())	return form()->usedVariables();
 
 	return {};
 }
 
+stringset Analysis::createdVariables()
+{
+	return DataSetPackage::pkg()->columnsCreatedByAnalysis(this);
+}
+
 void Analysis::runScriptRequestDone(const QString& result, const QString& controlName, bool hasError)
 {
 	if (_analysisForm)

Desktop/analysis/analysis.h

@@ -146,6 +146,7 @@ class Analysis : public AnalysisBase
 	performType				desiredPerformTypeFromAnalysisStatus()										const;
 
 	stringset				usedVariables();
+	stringset				createdVariables();
 	void					runScriptRequestDone(const QString & result, const QString & controlName, bool hasError);
 
 	void					setUpgradeMsgs(const Modules::UpgradeMsgs & msgs);

Desktop/data/computedcolumnsmodel.cpp

@@ -268,9 +268,11 @@ void ComputedColumnsModel::checkForDependentAnalyses(const std::string & columnN
 {
 	Analyses::analyses()->applyToAll([&](Analysis * analysis)
 		{
-			std::set<std::string> usedCols = analysis->usedVariables();
+			stringset	usedCols	= analysis->usedVariables(),
+						createdCols = analysis->createdVariables();
 
-			if(usedCols.count(columnName) > 0)
+			//Dont create an infinite loop please
+			if(usedCols.count(columnName) && !createdCols.count(columnName))
 			{
 				bool allColsValidated = true;
 

Desktop/data/datasetpackage.cpp

@@ -2600,11 +2600,25 @@ void DataSetPackage::checkComputedColumnDependenciesForAnalysis(Analysis * analy
 {
 	if(!_dataSet)
 		return;
-	
+
 	for(Column * col : _dataSet->columns())
 		if(col->isComputedByAnalysis(analysis->id()))
 			col->setDependsOn(analysis->usedVariables());
-		
+
+}
+
+stringset DataSetPackage::columnsCreatedByAnalysis(Analysis * analysis)
+{
+	if(!_dataSet)
+		return {};
+
+	stringset cols;
+
+	for(Column * col : _dataSet->columns())
+		if(col->analysisId() == analysis->id())
+			cols.insert(col->name());
+
+	return cols;
 }
 
 Column * DataSetPackage::createComputedColumn(const std::string & name, columnType type, computedColumnType desiredType, Analysis * analysis)

Desktop/data/datasetpackage.h

@@ -281,7 +281,8 @@ class DataSetPackage : public QAbstractItemModel //Not QAbstractTableModel becau
 				void						databaseStartSynching(bool syncImmediately);
 				void						databaseStopSynching();
 				bool						synchingExternally() const;
-				void						checkComputedColumnDependenciesForAnalysis(Analysis * analysis);
+				void						checkComputedColumnDependenciesForAnalysis(	Analysis * analysis);
+				stringset					columnsCreatedByAnalysis(					Analysis * analysis);
 				std::string					freeNewColumnName(size_t startHere);
 				void						dbDelete();