From 5abe9151f78907b32c70ad6b8cfc4eaa8874672d Mon Sep 17 00:00:00 2001
From: Shun Wang <shuonwang@gmail.com>
Date: Mon, 11 Nov 2024 15:26:25 +0800
Subject: [PATCH] return errors early to avoid long loop read excel file

---
 Desktop/data/importers/excelimporter.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Desktop/data/importers/excelimporter.cpp b/Desktop/data/importers/excelimporter.cpp
index f159407a0d..5d23ede062 100644
--- a/Desktop/data/importers/excelimporter.cpp
+++ b/Desktop/data/importers/excelimporter.cpp
@@ -18,6 +18,7 @@
 #include "excelimporter.h"
 #include "data/importers/excel/excel.h"
 #include "data/importers/excel/excelimportcolumn.h"
+#include "utilities/qutils.h"
 #include <columnutils.h>
 #include <string>
 #include <QFileInfo>
@@ -56,6 +57,9 @@ ImportDataSet* ExcelImporter::loadFile(const std::string &locator, std::function
 	cols = excel.countCols();
 	importColumns.reserve(cols);
 
+	if (cols == 0)
+		throw std::runtime_error(fq(tr("0 valid columns were read from the file, please check your data file.")));
+
 	for (uint32_t row = 0; row < rows; ++row) 
 	{
 		stringvec lineValues;