Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Problem when minimizing screen #2406

Closed
2 of 3 tasks
PerPalmgren opened this issue Nov 13, 2023 · 2 comments
Closed
2 of 3 tasks

[Bug]: Problem when minimizing screen #2406

PerPalmgren opened this issue Nov 13, 2023 · 2 comments
Assignees
@boutinb @JorisGoosen
Labels
Bug OS: Windows 10

Comments

@PerPalmgren
Copy link

PerPalmgren commented Nov 13, 2023 •
edited by JorisGoosen
Loading

JASP Version

0.18.1

Commit ID

No response

JASP Module

Other

What analysis are you seeing the problem on?

General

What OS are you seeing the problem on?

Windows 10

Bug Description

There seem to be a problem when minimizing the screen (I must do this some time when I work on a small screen). When minimizing it it is difficult to see and and you cant reach everything on the pane.

Expected Behaviour

You should be able to maximize and minimize window with full access to everything and be able to see everything.

Steps to Reproduce

Picture 1
Picture 2
Picture 3

Log (if any)

No response

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@boutinb boutinb assigned boutinb and JorisGoosen and unassigned Kucharssim Nov 14, 2023
@boutinb
Copy link
Contributor

boutinb commented Nov 14, 2023

Hi @PerPalmgren For the 2 first pictures, we should definitively fix this in the computed columns window.
For the 3rd one, the thing is that the minimum height of JASP is 640 (~pixel * dpi) * zoom scale. This might be higher than your screen (this is what shows the 3rd picture). This is of course quite subjective, but if we set it to a lower number so that it fits your screen, someone else with another screen can still say that it will be too big or too small. What you can still do is to play with the zoom scale (CTRL +/-), so that this minimum size can fit your screen.

JorisGoosen added a commit to JorisGoosen/jasp-desktop that referenced this issue Nov 15, 2023
@JorisGoosen
VariablesWindow should just show column info in a tab when it gets to…
6823541 
…o small

should solve jasp-stats/jasp-issues#2406 (computed column hard to see small window)
boutinb pushed a commit to jasp-stats/jasp-desktop that referenced this issue Nov 15, 2023
@JorisGoosen
JASP on the small screen (#5322)
9fbd814 
* FileMenu scrollable, better z and background
OSFLogin should handle being very small better

* VariablesWindow should just show column info in a tab when it gets too small

should solve jasp-stats/jasp-issues#2406 (computed column hard to see small window)

* Modules menu should also scroll in edit mode

* FileMenu now dynamically determines the required size for the buttons
This makes it smaller than it was before which makes the preference menus *just* usable on the minimumwindow size
I did move the treshold spinbox down a bit to make it fit

* also show column info for virtual column
@boutinb
Copy link
Contributor

boutinb commented Nov 16, 2023

Joris made a good job to solve this: jasp-stats/jasp-desktop#5322
The minimum height is set now to 400!

@boutinb boutinb closed this as completed Nov 16, 2023
JorisGoosen added a commit to jasp-stats/jasp-desktop that referenced this issue Jan 2, 2024
@JorisGoosen
JASP on the small screen (#5322)
ffffa36 
* FileMenu scrollable, better z and background
OSFLogin should handle being very small better

* VariablesWindow should just show column info in a tab when it gets too small

should solve jasp-stats/jasp-issues#2406 (computed column hard to see small window)

* Modules menu should also scroll in edit mode

* FileMenu now dynamically determines the required size for the buttons
This makes it smaller than it was before which makes the preference menus *just* usable on the minimumwindow size
I did move the treshold spinbox down a bit to make it fit

* also show column info for virtual column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boutinb boutinb

@JorisGoosen JorisGoosen

Labels
Bug OS: Windows 10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boutinb @Kucharssim @JorisGoosen @PerPalmgren