Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Black + also for "Edit Data" mode #2805

Closed
tomtomme opened this issue Jul 3, 2024 · 4 comments · Fixed by jasp-stats/jasp-desktop#5609
Closed

[Feature Request]: Black + also for "Edit Data" mode #2805

tomtomme opened this issue Jul 3, 2024 · 4 comments · Fixed by jasp-stats/jasp-desktop#5609

Comments

@tomtomme
Copy link
Member

tomtomme commented Jul 3, 2024

Description

Currently the black + button is only available in "Analysis" Mode

Purpose

Consistency. All data editing features should be available in "Data Edit" mode

Use-case

faster adding new variables

Is your feature request related to a problem?

Users search for the black + button in "Edit Data" mode and cannot find it.

Is your feature request related to a JASP module?

Unrelated

Describe the solution you would like

see title

Describe alternatives that you have considered

Add new vars via the "Insert" button while in "Edit Data" mode, but that feels slower because you have to choose from several options.

Additional context

image

@boutinb
Copy link
Contributor

boutinb commented Jul 3, 2024

This is a function that existed before Data Editing, but now in Edit mode, this function would be quite strange. Where to add it, since you can just click on the header of an empty column to add a (computed) column.

@tomtomme
Copy link
Member Author

tomtomme commented Jul 3, 2024

Interesting. I was not even aware of that possibility. This double clicking is an invisible feature. And that is why I like the expliciteness of the black +. And every student I know, who got to know the black + searches for it in "edit data" mode without success.

So I see some options:
a) Make it more visible that there is the possibility of double-clicking for a new variable within "edit data" mode. For example every empty column header could contain a +. Mockups below.
b) put the black + also in "edit data" mode
c) put the black + only in "edit data" mode, where it kind of belongs
d) nuking the black + alltogether

Atm a) seems the best to me, but my mockups do not look quite right yet:
xx
x
xsx

@EJWagenmakers
Copy link
Collaborator

The explicit x seems a good idea to me.

@boutinb
Copy link
Contributor

boutinb commented Jul 4, 2024

I would vote for the green + in Edit Mode, seems to me more intuitive.
Since we have now an Edit mode, I wanted to remove the back + in Analysis mode: adding a column seems to me an Edit function. But I was told that people would miss this functionality.

boutinb added a commit to boutinb/jasp-desktop that referenced this issue Jul 10, 2024
boutinb added a commit to jasp-stats/jasp-desktop that referenced this issue Jul 10, 2024
* Add + icon in header of the first virtual column

Fixes jasp-stats/jasp-issues#2805

* Add computedType to new column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants