Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: I cannot install the module template #3083

Open
2 of 3 tasks
bmatyasb opened this issue Dec 12, 2024 · 22 comments
Open
2 of 3 tasks

[Bug]: I cannot install the module template #3083

bmatyasb opened this issue Dec 12, 2024 · 22 comments
Assignees
Labels
Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. Developer

Comments

@bmatyasb
Copy link

JASP Version

0.19.2

Commit ID

No response

JASP Module

Unrelated

What analysis are you seeing the problem on?

No response

What OS are you seeing the problem on?

Windows 11

Bug Description

I would like to add extra functionality to JASP for myself. I think I have gone through the tutorial on adding modules. I saw that there is a template module. I downloaded it and thought I'd try loading it into JASP, testing to see if I had the simplest dependencies. But unfortunately it didn't work. I got an error message, I'll screenshot it. Is it just me, or is the template called jaspModule not really installable "by itself", just as downloaded?
Clipboard_12-12-2024_01

Expected Behaviour

Actually, I don't know : )

Steps to Reproduce

Download the template as a zip file (https://github.com/jasp-stats/jaspModuleTemplate).
Unpack, repack as targz.
JASP -> developer mode -> top right corner -> select the targz.

(in fact I tried to specify the source folder in the options (obviously not the targz file), and still no luck. )

Log (if any)

No response

More Debug Information

No response

Final Checklist

  • I have included a screenshot showcasing the issue, if possible.
  • I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • I have accurately described the bug, and steps to reproduce it.
@bmatyasb bmatyasb added the Bug label Dec 12, 2024
@tomtomme tomtomme added Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. and removed Bug labels Dec 12, 2024
@JorisGoosen
Copy link
Contributor

@bmatyasb yes there is some crucial parts of the template missing that would allow it to just be installed like that.

Currently @PabRod is working hard on upgrading the documentation and making the template immediately installable.
He is pretty far with this.

@RensDofferhoff
Copy link

You could build the module using RStudio and than load it from the resulting libpath.
This workflow might be easier as you are likely already familiar with using RStudio.

@bmatyasb
Copy link
Author

bmatyasb commented Dec 13, 2024 via email

@tomtomme
Copy link
Member

tomtomme commented Dec 13, 2024

This would be wonderful!!!

@JorisGoosen
Copy link
Contributor

thanks! I am very much looking forward to it. i would like to add tidyplot as a JASP module to allow a truly customized plot creation for anyone who wants it

This libpaths feature is included in the latest release that is currently live.
So you can give it a go if you like.

@tomtomme
Copy link
Member

@boutinb
I guess the "installing" label is not the best here - could we get a "developer" tag or soemthing like that?

@JorisGoosen
Copy link
Contributor

@bmatyasb we have a mattermost server where we do most of our internal communication. There is also a channel there specifically to help people who want to develop modules.

Would you like to be added to this?
Perhaps you can then send an email to [email protected], then we know what email to add. (Github will probably redact it here and you might not want to post it online anyway)

@bmatyasb
Copy link
Author

bmatyasb commented Dec 15, 2024 via email

@boutinb
Copy link
Contributor

boutinb commented Dec 16, 2024

@boutinb
I guess the "installing" label is not the best here - could we get a "developer" tag or soemthing like that?

Done

@tomtomme tomtomme self-assigned this Dec 18, 2024
@bmatyasb
Copy link
Author

Hi guys,
I think I can integrate the whole tidyplot into JASP, the basics are already working, it's not hard to add layers from here. I hope to have a version ready for testing by the end of January. For now it's in the Descriptives menu.
image

@tomtomme
Copy link
Member

@bmatyasb
Wow, just wow! Very nice to see. This will be a very valuable addition. Thank you so much!

@boutinb
Copy link
Contributor

boutinb commented Dec 19, 2024

Impressive @bmatyasb !

@bmatyasb
Copy link
Author

I'm doing pretty well. I think I'll be done by mid-January. The tidyplotting is really quite easy, very customizable :) However, I have a question. When I'm done, should I just compress the Package I created in RStudio and send it to you? I suppose you then build -> install package in RStudio in the same way as I did, and then load it as a developer module in JASP.
(...Unfortunately, I have not yet managed to compress it into tar.gz and install it as a plain module).

To which e-mail will I be able to send it?

image

@tomtomme
Copy link
Member

@bmatyasb
very very cool.

As far as I know, how to submit your module as tar.gz is described here in step 3, but this may be outdated:
https://github.com/jasp-stats/jasp-desktop/blob/development/Docs/development/jasp-module-workflow.md

@boutinb
can you confirm?

@shun2wang
Copy link
Contributor

I'm doing pretty well. I think I'll be done by mid-January. The tidyplotting is really quite easy, very customizable :) However, I have a question. When I'm done, should I just compress the Package I created in RStudio and send it to you? I suppose you then build -> install package in RStudio in the same way as I did, and then load it as a developer module in JASP.

Great works!

you can just create a github repo and we will fork your repo to build into JASP.

@EJWagenmakers
Copy link
Collaborator

Let me just chime in and echo how cool this is!!
EJ

@bmatyasb
Copy link
Author

bmatyasb commented Dec 31, 2024 via email

@tomtomme tomtomme assigned boutinb and vandenman and unassigned tomtomme Jan 1, 2025
@JorisGoosen
Copy link
Contributor

@bmatyasb how will you allow users to add multiple plots?

As in, they would have to come from the same analysis. So this would need some sort of list or entryfield for having multiple plots right?

The relevant option can then be used as dependencies for a jaspContainer to keep the plots in?
Because storing the plotobjects in the state seems a bit impractical and would probably become quite a hassle.

Perhaps joining our chatserver could be practical? The offer still stands and it would allow us to communicate easier.

@shun2wang
Copy link
Contributor

Perhaps joining our chatserver could be practical? The offer still stands and it would allow us to communicate easier.

I had just invited @bmatyasb to join in our channel ^^ please check your e-mail messages.

@bmatyasb
Copy link
Author

bmatyasb commented Jan 2, 2025

@JorisGoosen Finally, I solved it by using tabView to create multiple plots, and then using the cowplot package's plot_grid() function to join these plots together in a specified number of columns and rows. of course the individual plots and the grid are in separate containers.
Supposedly I got an invitation, will join soon. thanks!

@tomtomme
Copy link
Member

@bmatyasb
how is it going? Anything you need?

@bmatyasb
Copy link
Author

bmatyasb commented Jan 23, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: High Bugs that are negatively affecting the area of the program, but don't need immediate fix. Developer
Projects
None yet
Development

No branches or pull requests

9 participants