Skip to content

Commit 1c71257

Browse files
kashikenormanmaurer
kashike
authored andcommitted
Provide an Automatic-Module-Name for the netty-all artifact fixes netty#7644
Motivation: The netty-all artifact doesn't have a Automatic-Module-Name defined in the manifest like the rest of the projects do, resulting in requires netty.all. Modification: Add Automatic-Module-Name Result: Correctly work as java9 module.
1 parent 7f23c34 commit 1c71257

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

README.md

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ Netty can be used in modular JDK9 applications as a collection of automatic modu
3131
reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They
3232
are listed below:
3333

34+
* `io.netty.all`
3435
* `io.netty.buffer`
3536
* `io.netty.codec`
3637
* `io.netty.codec.dns`

all/pom.xml

+3
Original file line numberDiff line numberDiff line change
@@ -664,6 +664,9 @@
664664
<manifest>
665665
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
666666
</manifest>
667+
<manifestEntries>
668+
<Automatic-Module-Name>io.netty.all</Automatic-Module-Name>
669+
</manifestEntries>
667670
<index>true</index>
668671
</archive>
669672
</configuration>

0 commit comments

Comments
 (0)