Skip to content

Commit bca4c3a

Browse files
committed
Updated Find Bugs configuration
1 parent 3a8b929 commit bca4c3a

File tree

2 files changed

+52
-12
lines changed

2 files changed

+52
-12
lines changed

.fbfilter.xml

+37
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<FindBugsFilter>
3+
<!-- Tests -->
4+
<Match>
5+
<Class name="~.*Test(\$[^\$]+)*"/>
6+
</Match>
7+
<!-- Generated code -->
8+
<Match>
9+
<Class name="~.*\.LocalTimeProtocol(\$[^\$]+)*"/>
10+
</Match>
11+
<!-- Noise -->
12+
<Match>
13+
<Bug code="Co,SF"
14+
category="I18N"
15+
pattern="REC_CATCH_EXCEPTION,UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR,DB_DUPLICATE_SWITCH_CLAUSES,VO_VOLATILE_REFERENCE_TO_ARRAY" />
16+
</Match>
17+
<!-- Known false positives -->
18+
<Match>
19+
<Class name="~.*Channel(Group)?Future"/>
20+
<Method name="~await.*"/>
21+
<Bug pattern="PS_PUBLIC_SEMAPHORES"/>
22+
</Match>
23+
<Match>
24+
<Class name="~.*SelectorLoop"/>
25+
<Method name="run"/>
26+
<Bug code="ESync"/>
27+
</Match>
28+
<!-- Known issues that don't matter -->
29+
<Match>
30+
<Or>
31+
<Class name="~.*\.util\.Concurrent[A-Za-z]*HashMap(\$[^\$]+)*"/>
32+
<Class name="~.*\.util\..*TransferQueue(\$[^\$]+)*"/>
33+
<Class name="~.*\.util\.MapBackedSet"/>
34+
</Or>
35+
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED,SE_BAD_FIELD"/>
36+
</Match>
37+
</FindBugsFilter>

.fbprefs

+15-12
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
#FindBugs User Preferences
2-
#Fri Feb 13 19:51:40 KST 2009
2+
#Wed Mar 04 19:28:55 KST 2009
33
detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true
4-
detectorBCPMethodReturnCheck=BCPMethodReturnCheck|false
4+
detectorBCPMethodReturnCheck=BCPMethodReturnCheck|true
55
detectorBadAppletConstructor=BadAppletConstructor|true
66
detectorBadResultSetAccess=BadResultSetAccess|true
77
detectorBadSyntaxForRegularExpression=BadSyntaxForRegularExpression|true
88
detectorBadUseOfReturnValue=BadUseOfReturnValue|true
99
detectorBadlyOverriddenAdapter=BadlyOverriddenAdapter|true
1010
detectorBooleanReturnNull=BooleanReturnNull|true
11-
detectorBuildInterproceduralCallGraph=BuildInterproceduralCallGraph|false
11+
detectorBuildInterproceduralCallGraph=BuildInterproceduralCallGraph|true
1212
detectorBuildObligationPolicyDatabase=BuildObligationPolicyDatabase|true
1313
detectorCallToUnsupportedMethod=CallToUnsupportedMethod|true
1414
detectorCalledMethods=CalledMethods|true
@@ -29,13 +29,13 @@ detectorDumbMethodInvocations=DumbMethodInvocations|true
2929
detectorDumbMethods=DumbMethods|true
3030
detectorDuplicateBranches=DuplicateBranches|true
3131
detectorEmptyZipFileEntry=EmptyZipFileEntry|true
32-
detectorEqStringTest=EqStringTest|false
32+
detectorEqStringTest=EqStringTest|true
3333
detectorEqualsOperandShouldHaveClassCompatibleWithThis=EqualsOperandShouldHaveClassCompatibleWithThis|true
3434
detectorFieldItemSummary=FieldItemSummary|true
3535
detectorFinalizerNullsFields=FinalizerNullsFields|true
36-
detectorFindBadCast=FindBadCast|false
36+
detectorFindBadCast=FindBadCast|true
3737
detectorFindBadCast2=FindBadCast2|true
38-
detectorFindBadEqualsImplementation=FindBadEqualsImplementation|false
38+
detectorFindBadEqualsImplementation=FindBadEqualsImplementation|true
3939
detectorFindBadForLoop=FindBadForLoop|true
4040
detectorFindBugsSummaryStats=FindBugsSummaryStats|true
4141
detectorFindCircularDependencies=FindCircularDependencies|false
@@ -94,13 +94,15 @@ detectorInvalidJUnitTest=InvalidJUnitTest|true
9494
detectorIteratorIdioms=IteratorIdioms|true
9595
detectorLazyInit=LazyInit|true
9696
detectorLoadOfKnownNullValue=LoadOfKnownNullValue|true
97-
detectorLockedFields=LockedFields|false
97+
detectorLockedFields=LockedFields|true
9898
detectorMethodReturnCheck=MethodReturnCheck|true
9999
detectorMethods=Methods|true
100100
detectorMultithreadedInstanceAccess=MultithreadedInstanceAccess|true
101101
detectorMutableLock=MutableLock|true
102102
detectorMutableStaticFields=MutableStaticFields|true
103103
detectorNaming=Naming|true
104+
detectorNoise=Noise|false
105+
detectorNoiseNullDeref=NoiseNullDeref|false
104106
detectorNoteAnnotationRetention=NoteAnnotationRetention|true
105107
detectorNoteCheckReturnValue=NoteCheckReturnValue|true
106108
detectorNoteCheckReturnValueAnnotations=NoteCheckReturnValueAnnotations|true
@@ -113,13 +115,13 @@ detectorNoteUnconditionalParamDerefs=NoteUnconditionalParamDerefs|true
113115
detectorNumberConstructor=NumberConstructor|true
114116
detectorOverridingEqualsNotSymmetrical=OverridingEqualsNotSymmetrical|true
115117
detectorPreferZeroLengthArrays=PreferZeroLengthArrays|true
116-
detectorPublicSemaphores=PublicSemaphores|false
118+
detectorPublicSemaphores=PublicSemaphores|true
117119
detectorQuestionableBooleanAssignment=QuestionableBooleanAssignment|true
118120
detectorReadReturnShouldBeChecked=ReadReturnShouldBeChecked|true
119121
detectorRedundantInterfaces=RedundantInterfaces|true
120122
detectorReflectiveClasses=ReflectiveClasses|true
121123
detectorRepeatedConditionals=RepeatedConditionals|true
122-
detectorResolveAllReferences=ResolveAllReferences|false
124+
detectorResolveAllReferences=ResolveAllReferences|true
123125
detectorRuntimeExceptionCapture=RuntimeExceptionCapture|true
124126
detectorSerializableIdiom=SerializableIdiom|true
125127
detectorStartInConstructor=StartInConstructor|true
@@ -149,8 +151,9 @@ detectorVolatileUsage=VolatileUsage|true
149151
detectorWaitInLoop=WaitInLoop|true
150152
detectorWrongMapIterator=WrongMapIterator|true
151153
detectorXMLFactoryBypass=XMLFactoryBypass|true
152-
detector_threshold=2
154+
detector_threshold=3
153155
effort=max
154-
filter_settings=Medium|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false
155-
filter_settings_neg=|
156+
excludefilter0=.fbfilter.xml
157+
filter_settings=Low|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false
158+
filter_settings_neg=NOISE|
156159
run_at_full_build=true

0 commit comments

Comments
 (0)